[gentoo-dev] CUSTOM cflags replacement snippet

[gentoo-dev] CUSTOM cflags replacement snippet

[Chris White]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

All,

    I created this quick little function to recursively patch Makefiles 
with custom CFLAGS.

custom_cflags() {
    for directories in *
    do
        if [ -d $directories -a -e $directories/Makefile ]
        then
            cd $directories
            for subdirectories in *
            do
                if [ -d $subdirectories -a -e $subdirectories/Makefile ]
                then
                    custom_cflags
                fi
            done

            sed -i \
            -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" Makefile \
            -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" Makefile \
            || die "Could not patch $directories/Makefile for custom CFLAGS"

            cd ..
        fi
    done
}

Known issues:

if CFLAGS have something such as -Iblah or -D__BREAKS__WITHOUT__THIS__, 
you're screwed. 
if CFLAGS are added onto at some point (CFLAGS = $CFLAGS -mnewflag), 
you're screwed.
It's not perfect, but it works for me in most cases.

Go ahead and flame, just thought I'd toss it here to make people's lives 
2% easier :).

-- 
Chris White <chriswhite@gentoo.org>
------------------------
Sound   | Video   | Security
Mozilla | Haskell | Lang-misc
ChrisWhite @ irc.freenode.net


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Eldad Zack]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

On Saturday 20 November 2004 08:14, Chris White wrote:
>     I created this quick little function to recursively patch Makefiles
> with custom CFLAGS.

wouldn't it be simpler to do:

for dir in $(find -name "Makefile" .)
do
 sed -i \
        -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" \
        -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" \
 ${dir} \
        || die "Could not patch $directories/Makefile for custom CFLAGS"
done


-- 
Eldad Zack <eldad@gentoo.org>
Key/Fingerprint at pgp.mit.edu, ID 0x96EA0A93

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Eldad Zack]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

On Saturday 20 November 2004 13:28, Eldad Zack wrote:
> On Saturday 20 November 2004 08:14, Chris White wrote:
> >     I created this quick little function to recursively patch Makefiles
> > with custom CFLAGS.
>
> wouldn't it be simpler to do:

What I really meant was:

for makefile in $(find -name "Makefile" .)
do
 sed -i \
 -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" \
 -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" \
 ${makefile} \
 || die "Could not patch ${makefile} for custom CFLAGS"
done

-- 
Eldad Zack <eldad@gentoo.org>
Key/Fingerprint at pgp.mit.edu, ID 0x96EA0A93

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: CUSTOM cflags replacement snippet

[Michael Sterrett -Mr. Bones.-]

On Sat, 20 Nov 2004, Eldad Zack wrote:

> for makefile in $(find -name "Makefile" .)
> do
>  sed -i \
>  -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" \
>  -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" \
>  ${makefile} \
>  || die "Could not patch ${makefile} for custom CFLAGS"
> done

This stuff all fails if C*FLAGS has a ':' in it.  There's a bug about
bad sed like this in bugzilla.

Also, sed takes a list.  So never loop when you can just pass all the files
to sed.  And don't forget about filenames with whitespace in the name...

Michael Sterrett
  -Mr. Bones.-
mr_bones_@gentoo.org

--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Georgi Georgiev]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

maillog: 20/11/2004-13:31:42(+0200): Eldad Zack types
> On Saturday 20 November 2004 13:28, Eldad Zack wrote:
> > On Saturday 20 November 2004 08:14, Chris White wrote:
> > >     I created this quick little function to recursively patch Makefiles
> > > with custom CFLAGS.
> >
> > wouldn't it be simpler to do:
> 
> What I really meant was:
> 
> for makefile in $(find -name "Makefile" .)
> do
>  sed -i \
>  -e "s:^CFLAGS.*:CFLAGS = ${CFLAGS}:" \
>  -e "s:^CXXFLAGS.*:CXXFLAGS = ${CXXFLAGS}:" \
>  ${makefile} \
>  || die "Could not patch ${makefile} for custom CFLAGS"
> done

Instead of replacing all Makefiles, couldn't one simply
make "CFLAGS=${CFLAGS}" "CXXFLAGS=${CXXFLAGS}"
?

-- 
 )   Georgi Georgiev    ) RAM wasn't built in a day.                    )
(     chutz@gg3.net    (                                               (
 )  +81(90)6266-1163    )                                               )

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Aron Griffis]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Georgi Georgiev wrote:	[Sat Nov 20 2004, 10:18:31AM EST]
> Instead of replacing all Makefiles, couldn't one simply
> make "CFLAGS=${CFLAGS}" "CXXFLAGS=${CXXFLAGS}"

Yes, writing to the Makefiles is unnecessary.

Regards,
Aron

--
Aron Griffis
Gentoo Linux Developer


[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]

Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Aron Griffis]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

Chris,

Chris White wrote:	[Sat Nov 20 2004, 01:14:46AM EST]
> Go ahead and flame, just thought I'd toss it here to make people's lives 
> 2% easier :).

As was mentioned later in the thread, this is not the right approach.
Sedding the Makefiles is error-prone because you use a variable in the
RHS of the sed expression.  Whether it works for you in your limited
tests is irrelevant.  You shouldn't be willingly inserting error-prone
code into ebuilds.

There are two different ways you can deal with the CFLAGS issue
instead.  Both are better than the sed method.

1. If the Makefiles are well-constructed and flags are appropriate
   passed to sub-makes, then you can do:

        emake CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"

2. If the Makefiles do lazy assignment of variables instead of
   immediate assignment, then you can simply append a new assignment
   to the bottom of the ebuild.  Here is the comparison of lazy vs.
   immediately assignment:

        # lazy assignment
        CFLAGS = -g

        # immediate assignment
        CFLAGS := -g

   Almost all Makefiles use lazy assignment.  In that case you can use
   a snippet like the following which will override all previous
   assignments in the ebuild:

        find "${S}" -name Makefile | while read mf; do
            printf "\n\nCFLAGS = %s\nCXXFLAGS = %s\n" \
                "${CFLAGS}" "${CXXFLAGS}" >> "$mf"
        done

Regards,
Aron

--
Aron Griffis
Gentoo Linux Developer


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]