From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7234F158020 for ; Wed, 14 Dec 2022 08:49:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 93EF5E0824; Wed, 14 Dec 2022 08:49:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 60E53E07DB for ; Wed, 14 Dec 2022 08:49:50 +0000 (UTC) Message-ID: <3d6d287114f27cbb721c15001f1d0370017398f8.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] unpacker.eclass: fix unpack_gpkg with TAPE set From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: base-system@gentoo.org, Sam James Date: Wed, 14 Dec 2022 09:49:45 +0100 In-Reply-To: <20221214084819.481411-1-sam@gentoo.org> References: <20221214084819.481411-1-sam@gentoo.org> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: ebdb8d07-18f5-4e09-9c7e-c3c4b2cc2909 X-Archives-Hash: c1bd46dc66d420ccf38c2b02d0ca8037 On Wed, 2022-12-14 at 08:48 +0000, Sam James wrote: > Closes: https://bugs.gentoo.org/885719 > Signed-off-by: Sam James > --- > eclass/unpacker.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass > index 11f04fde7226..5ce681ebaa0d 100644 > --- a/eclass/unpacker.eclass > +++ b/eclass/unpacker.eclass > @@ -487,7 +487,7 @@ unpack_gpkg() { > local dirname=3D${images[0]%/*} > mkdir -p "${dirname}" || die > tar -xOf "${gpkg}" "${images[0]}" | ${decomp:-cat} | > - tar --no-same-owner -xC "${dirname}" > + tar --no-same-owner -C "${dirname}" -xf - > assert "Unpacking ${gpkg} failed" > } > =20 LGTM. Thanks! --=20 Best regards, Micha=C5=82 G=C3=B3rny