From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KccZa-0000kx-RE for garchives@archives.gentoo.org; Mon, 08 Sep 2008 08:58:15 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 291E8E032D; Mon, 8 Sep 2008 08:58:12 +0000 (UTC) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.239]) by pigeon.gentoo.org (Postfix) with ESMTP id F2851E032D for ; Mon, 8 Sep 2008 08:58:11 +0000 (UTC) Received: by wr-out-0506.google.com with SMTP id c37so1435308wra.26 for ; Mon, 08 Sep 2008 01:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=S0TvhL47AH/4wSDky9DOASKYrjPYKyMXOj+iOrPiG9M=; b=hvz9CJ1tXR+Hj2S27C1op79M2EHu59gisXr7eYXUEf0GfGIthiZMIeQER84nVrONxY AQPuwkxxzkziulfcAP7Q02UkGPkbTJcjNDwOAjbfTVcZIpxzAoE6zR+fbxlL1840EDAt e5K95ngxqFvJ8YrWQU+n4I3+iRo9V9j9A5s7Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Y/ppopH9x31U7+qxS+dBMiStZ9cOrqJqLf6PLEBPZkgqWK8DrxjMT+iZxwu1hkyz/9 8yfNYubR2+9JXiaGLL+UFIOBtPvo3YaRo+P7g05tjdBmJQNoWj7yu5fSjHbMFUNeZwR4 Vjrdnm66JdZ9nMOvwsFrnSL/XSnW2O/82Wvus= Received: by 10.90.86.9 with SMTP id j9mr18945453agb.11.1220864291047; Mon, 08 Sep 2008 01:58:11 -0700 (PDT) Received: by 10.90.49.6 with HTTP; Mon, 8 Sep 2008 01:58:10 -0700 (PDT) Message-ID: <3c32af40809080158o3b63e23eg45b64ee574e44530@mail.gmail.com> Date: Mon, 8 Sep 2008 10:58:10 +0200 From: "Santiago M. Mola" Sender: cooldwind@gmail.com To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile In-Reply-To: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Google-Sender-Auth: 643e3219dd19c6d0 X-Archives-Salt: 3bb84175-e1bb-4bf4-892b-808a1a87271f X-Archives-Hash: 8b90278f7dd39453e472debfc675ddd1 On Mon, Sep 8, 2008 at 10:44 AM, Alec Warner wrote: > > Most obvious failure cases these days have build logs and the build > logs will specify what the configure command > was, so the only problematic area is looking at the ebuild to > determine what will happen during execution. Arguably having > an ebuildshell would assist here. However, ebuilds are already > sufficiently complicated by eclass inheritance that reading > many ebuilds is already difficult and I think this extension does not > make that significantly worse. If you're just dealing with the default phases, it's not too hard to say in advance the exact command that will be executed. Default phases are well-defined in PMS. So you can look at them to see what will happend if you define some variable. For example, for the proposed arguments for src_configure, a definition would be something like this (taken from Exherbo, just pretend it says USE instead OPTION and you're done): default_src_configure() { if [[ -x ${ECONF_SOURCE:-.}/configure ]] ; then econf \ "${DEFAULT_SRC_CONFIGURE_PARAMS[@]}" \ $(for s in "${DEFAULT_SRC_CONFIGURE_OPTION_ENABLES}" ; do \ option_enable ${s} ; \ done ) \ $(for s in "${DEFAULT_SRC_CONFIGURE_OPTION_WITHS}" ; do \ option_with ${s} ; \ done ) fi } It's quite straightforward. Regards, -- Santiago M. Mola Jabber ID: cooldwind@gmail.com