From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kc4fN-0004ZX-W3 for garchives@archives.gentoo.org; Sat, 06 Sep 2008 20:45:58 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5A227E0348; Sat, 6 Sep 2008 20:45:57 +0000 (UTC) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.231]) by pigeon.gentoo.org (Postfix) with ESMTP id 38416E0348 for ; Sat, 6 Sep 2008 20:45:57 +0000 (UTC) Received: by wr-out-0506.google.com with SMTP id c37so979344wra.26 for ; Sat, 06 Sep 2008 13:45:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=/iASZYnXZx7QSxuo4nprl4nSOK4FqPHR0boui9A1toU=; b=Kudr3ucs+i0D48akVflqYz03vod+IGeg5QEQsMTFLnOURyRd/MCLmFXQjv0r7qkxlj YELLb/qWWzAocgRX8fUcUiGdZpjV/yQqTYCtYj5T1gz5k4X4Ao2l7G0lfIIxMgOawlKW WR5f0iLijVaBmuLLwhY/hdV7D/jDHdqj6dec0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=lbO636xqwzpf19+M6ScOde1UrIqJAnXxQwITKLLNcq/WhqZkVEBz2tNQKr4liSPiRJ reSO5q/GbXCk8TgWtJNY3hP/TwhObOEy4zhe8DFQK8gxaahgxe/9RwfiB6zNnoq8fA0e 169NiD4qT13KlPi34mgp3P73Eo3/pj9kvzSP8= Received: by 10.90.98.13 with SMTP id v13mr16902945agb.54.1220733956268; Sat, 06 Sep 2008 13:45:56 -0700 (PDT) Received: by 10.90.49.6 with HTTP; Sat, 6 Sep 2008 13:45:56 -0700 (PDT) Message-ID: <3c32af40809061345u5d8e2a44kcf01367525f2db28@mail.gmail.com> Date: Sat, 6 Sep 2008 22:45:56 +0200 From: "Santiago M. Mola" Sender: cooldwind@gmail.com To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile In-Reply-To: <48C2E3C5.5040701@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080906173656.GB5434@spoc.mpa.com> <48C2E3C5.5040701@gentoo.org> X-Google-Sender-Auth: c88693c6b9a09875 X-Archives-Salt: e508becf-e7e7-45b0-8cb9-34c55086d2cf X-Archives-Hash: 60d6809a885e3c9784ab82fe628a3475 On Sat, Sep 6, 2008 at 10:10 PM, Ben de Groot wrote: > Alec Warner wrote: >> On Sat, Sep 6, 2008 at 10:36 AM, Thomas Anderson wrote: >>> Hi, >>> Currently we have a lot of: >>> src_configure() { >>> econf $(use_enable dvdr) \ >>> $(use_with ipv6 ssl) \ >>> --with-system-zlib >>> } >>> >>> Introducing(Idea shamelessly taken from Exherbo): >>> DEFAULT_SRC_CONFIGURE_USE_{WITHS,ENABLES} >>> DEFAULT_SRc_CONFIGURE_EXTRA_PARAMS >>> >>> The code from above could be rewritten like so: >>> >>> DEFAULT_SRC_CONFIGURE_USE_ENABLES=( 'dvdr' ) >>> DEFAULT_SRC_CONFIGURE_USE_WITHS=( 'ipv6 ssl' ) >>> DEFAULT_SRC_CONFIGURE_EXTRA_PARAMS=( '--with-system-zlib' ) >>> >>> That's much simpler. >> >> It saves you 1 line and reduces readability and intuitiveness by a >> fair margin; how is it simpler? > > It may be 2 lines less, but it is 42 characters more. > Plus, I dislike caps. :-p In the example I posted it's 339 characters less. Almost half of the original ;-) Regards, -- Santiago M. Mola Jabber ID: cooldwind@gmail.com