Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile

["Santiago M. Mola" <coldwind@gentoo.org>]

On Sat, Sep 6, 2008 at 10:10 PM, Ben de Groot <yngwin@gentoo.org> wrote:
> Alec Warner wrote:
>> On Sat, Sep 6, 2008 at 10:36 AM, Thomas Anderson <gentoofan23@gentoo.org> wrote:
>>> Hi,
>>>        Currently we have a lot of:
>>>                src_configure() {
>>>                        econf $(use_enable dvdr) \
>>>                                $(use_with ipv6 ssl) \
>>>                                --with-system-zlib
>>>                }
>>>
>>>        Introducing(Idea shamelessly taken from Exherbo):
>>>                DEFAULT_SRC_CONFIGURE_USE_{WITHS,ENABLES}
>>>                DEFAULT_SRc_CONFIGURE_EXTRA_PARAMS
>>>
>>>        The code from above could be rewritten like so:
>>>
>>>        DEFAULT_SRC_CONFIGURE_USE_ENABLES=( 'dvdr' )
>>>        DEFAULT_SRC_CONFIGURE_USE_WITHS=( 'ipv6 ssl' )
>>>        DEFAULT_SRC_CONFIGURE_EXTRA_PARAMS=( '--with-system-zlib' )
>>>
>>>        That's much simpler.
>>
>> It saves you 1 line and reduces readability and intuitiveness by a
>> fair margin; how is it simpler?
>
> It may be 2 lines less, but it is 42 characters more.
> Plus, I dislike caps. :-p

In the example I posted it's 339 characters less. Almost half of the
original ;-)

Regards,
-- 
Santiago M. Mola
Jabber ID: cooldwind@gmail.com