public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Florian Schmaus <flow@gentoo.org>
To: Sam James <sam@gentoo.org>, gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] gradle.eclass: add new eclass
Date: Sat, 7 Jan 2023 11:58:24 +0100	[thread overview]
Message-ID: <3b1aa701-c0b8-cde2-3590-6ea629b7214f@gentoo.org> (raw)
In-Reply-To: <44DF820D-602C-4DE6-8BE7-B9E3A858B53D@gentoo.org>

On 07/01/2023 05.29, Sam James wrote:
> 
> 
>> On 6 Jan 2023, at 17:20, Florian Schmaus <flow@gentoo.org> wrote:
>>
>> Signed-off-by: Florian Schmaus <flow@gentoo.org>
>> ---
>> eclass/gradle.eclass   | 149 +++++++++++++++++++++++++++++++++++++++++
>> eclass/tests/gradle.sh |  62 +++++++++++++++++
>> 2 files changed, 211 insertions(+)
>> create mode 100644 eclass/gradle.eclass
>> create mode 100755 eclass/tests/gradle.sh
>>
>> diff --git a/eclass/gradle.eclass b/eclass/gradle.eclass
>> [...]
> 
>> +
>> +# @ECLASS_VARIABLE: EGRADLE_MIN
>> +# @DEFAULT_UNSET
>> +# @DESCRIPTION:
>> +# Minimum required gradle version.
>> +
>> +# @ECLASS_VARIABLE: EGRADLE_MAX_EXCLUSIVE
>> +# @DEFAULT_UNSET
>> +# @DESCRIPTION:
>> +# First gradle version that is not supported.
>> +
>> +# @ECLASS_VARIABLE: EGRADLE_EXACT_VER
>> +# @DEFAULT_UNSET
>> +# @DESCRIPTION:
>> +# The exact required gradle version.
>> +
> 
> It feels a pity to not use the now-somewhat standard
> PYTHON_COMPAT/LUA_COMPAT-style API.
> 
> Is there a reason not to?
> 
> If it doesn't fit how Gradle versioning works / the
> number of targets is likely to be far too high,
> It's fine as-is.

The _COMPAT-style API would work for Java LTS versions, but not for fast 
moving targets like Gradle versions.

Gradle has overall a good compatibility story, breaking changes are 
typically just introduced in new major versions. But sometimes you need 
a particular Gradle version range, like [6.2,6.8) due the mixins of 
Gradle plugins.

I expect that the number of Java projects that use Gradle will continue 
to grow. Because of that we probably need to provide a diverse range of 
Gradle versions.

- Flow


  reply	other threads:[~2023-01-07 10:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 17:20 [gentoo-dev] RFC: new gradle.eclass Florian Schmaus
2023-01-06 17:20 ` [gentoo-dev] [PATCH] gradle.eclass: add new eclass Florian Schmaus
2023-01-07  4:29   ` Sam James
2023-01-07 10:58     ` Florian Schmaus [this message]
2023-01-07  6:07   ` Anna
2023-01-06 17:51 ` [gentoo-dev] RFC: new gradle.eclass Maciej Barć
2023-01-06 18:52 ` Yuan Liao (Leo)
2023-01-06 19:40   ` Florian Schmaus
2023-06-28  7:52 ` [gentoo-dev] [PATCH 0/2] " Florian Schmaus
2023-06-28  7:52   ` [gentoo-dev] [PATCH 1/2] gradle.eclass: add new eclass Florian Schmaus
2023-06-28  8:51     ` Michał Górny
2023-06-28  9:21     ` Ulrich Mueller
2023-06-28  7:52   ` [gentoo-dev] [PATCH 2/2] dev-java/openjfx: switch to gradle.eclass Florian Schmaus
2023-06-30  8:39   ` [gentoo-dev] [PATCH 0/2] new gradle.eclass Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b1aa701-c0b8-cde2-3590-6ea629b7214f@gentoo.org \
    --to=flow@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox