public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Pagano <mpagano@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] [PATCH 1/1] linux-mod.eclass: Remove econf call in compile phase, function
Date: Sat, 10 Dec 2022 12:52:18 -0500	[thread overview]
Message-ID: <3ab3d0e0-27d0-d81f-c7a7-b5141a000729@gentoo.org> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 1464 bytes --]

Remove the econf call in linux-mod_src_compile as it is
deprecated in later versions of EAPI. There is no current use
of this functionality in the official gentoo repo and will close
a 12 year old bug.

Bug: https://bugs.gentoo.org/340597

Signed-off-by: Mike Pagano <mpagano@gentoo.org>
---
  eclass/linux-mod.eclass | 7 -------
  1 file changed, 7 deletions(-)

diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
index ff2294f1e..5655ac73a 100644
--- a/eclass/linux-mod.eclass
+++ b/eclass/linux-mod.eclass
@@ -649,13 +649,6 @@ linux-mod_src_compile() {
     then
       cd "${srcdir}"
       ln -s "${S}"/Module.symvers Module.symvers
-     einfo "Preparing ${modulename} module"
-     if [[ -n ${ECONF_PARAMS} ]]
-     then
-       eqawarn "This package relies on the deprecated functionality of econf being called in linux-mod_src_compile (ECONF_PARAMS), which will go away in 30 days (20230107) (https://bugs.gentoo.org/340597)"
-       econf ${ECONF_PARAMS} || \
-       die "Unable to run econf ${ECONF_PARAMS}"
-     fi

       # This looks messy, but it is needed to handle multiple variables
       # being passed in the BUILD_* stuff where the variables also have
-- 
2.37.4


-- 
Mike Pagano
Gentoo Developer - Kernel Project
E-Mail     : mpagano@gentoo.org
GnuPG FP   : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
Public Key : http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 16505 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

                 reply	other threads:[~2022-12-10 17:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ab3d0e0-27d0-d81f-c7a7-b5141a000729@gentoo.org \
    --to=mpagano@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox