From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E7B49158086 for ; Sun, 26 Dec 2021 10:17:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 439212BC035; Sun, 26 Dec 2021 10:17:43 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3C8762BC008 for ; Sun, 26 Dec 2021 10:17:42 +0000 (UTC) Message-ID: <3a8cfa13f644f63dcb996b1158c5714c8bdc53f0.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/5] gnome2-utils.eclass: phase out emktemp From: Mart Raudsepp To: gentoo-dev@lists.gentoo.org Date: Sun, 26 Dec 2021 12:17:34 +0200 In-Reply-To: References: <20211209132325.297913-1-marecki@gentoo.org> <20211209132325.297913-2-marecki@gentoo.org> <1f731fd5d6309bf1ebeb8e08b73ca903a1bc47dc.camel@gentoo.org> <136a9c8c1a600ca22f4facdb8de8feb3ba0bb818.camel@gentoo.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ooQWMYcjy3Hf0Dcp6ivh" User-Agent: Evolution 3.42.2 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 56c0eef0-bf88-41b3-9365-8c0e0af00945 X-Archives-Hash: 34c81253d10f6b2d21ba5c3a1d0eb4ac --=-ooQWMYcjy3Hf0Dcp6ivh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =C3=9Chel kenal p=C3=A4eval, P, 26.12.2021 kell 10:50, kirjutas Micha=C5=82= G=C3=B3rny: > On Sun, 2021-12-26 at 09:44 +0000, Marek Szuba wrote: > >=20 > > On 13 December 2021 17:24:18 UTC, Mart Raudsepp > > wrote: > >=20 > > > Actually I kind of preferred a static name over straight mktemp, > > > because emktemp supported other cases than a pure mktemp usage > > > does. > > > But I don't know if it could ever clash things in some weird > > > situations. > >=20 > > That last part is the message I tried to convey in my e-mail, sorry > > if I wasn't clear enough. > >=20 > > Anyway, could anyone with more Postage/PMS experience weigh in on > > this? If it is indeed safe then the eclass could be modified > > further, e.g. to use static names with EAPI-8+ but stick with > > mktemp for older EAPIs just to be safe. >=20 > I suppose it's not specified strictly but T should be safe for all > sane > uses.=C2=A0 If it weren't, we'd already be in deep trouble and gnome2- > utils > would be the least of our concerns. >=20 > That said, making this EAPI-conditional is just an unnecessary > complexity. It's already hardcoded to $T via using mktemp instead of emktemp (which supported lack of $T or mktemp utility, unlike the replacement that was merged) - so if $T and mktemp is guaranteed, we are good there. It was introduced with mktemp in the first place and then vapier changed it to emktemp without any reason given beyond probably just doing it for everything to support lack of mktemp on the system or some such. Now the question was, can we hardcode the name instead - is it possible for it to be running things in parallel and clash on the name, e.g.: * postinst and postrm ran at the same time on replacement: is it doing ._unmerge dir in portage an implementation detail that we shouldn't rely on it? * postinst and/or postrm ran with multilib support: could they be running in parallel in the future for the different ABIs -- should we include the ABI in the static filename at least to avoid clashes there? Mart --=-ooQWMYcjy3Hf0Dcp6ivh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAABCgB9FiEEUdZn9pOq0mlNjRvdEKbJ+k9JlgYFAmHIQT5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDUx RDY2N0Y2OTNBQUQyNjk0RDhEMUJERDEwQTZDOUZBNEY0OTk2MDYACgkQEKbJ+k9J lgYRNQ/+LkC0ZtLYsDga9nmlxPCvwn2y2tKMVbFWIY1HAUI3Ugcf9HZ8PdXJNOul 181Gw6XnfsYl6ddteAQCfiL6D593p7S7KXCvvanGYuQvrI3fWvBIjCALlLx1ke7N i+Pxb/uP/fW/OWI+G4U6Cy9WtlSYlTE1LKtlrbbh8FLejkCCnCcCkWE8AWUoPdCL w+70D7Dkj5D/Kd5uab606mb1c6adzpjPCwr/GDSOv6h6K2LpThPiQJ7+qYEo2s5g AQQqtxvQxw+yJZdgwW5DbDV6DQdKEwzfczrcfXZw4N4INqfSXAX2bCxvQwnbAqS5 sH0EXIlYCpt9RH1EgArsh+uv1f9kg6xM5onplumChAiI3t7jxmPpRheUZPms3O7e 4sSTb7aNYi7A0hxLUkchZuBfYIRBhErexiFGfn1e/XgZgdsfV5Medlz/1BcelvP8 wRoXiTmxuZk4cjI1YXMthr8biYauXN6Qy1tg1opSozz8mPfpWsUtjT8vcvd9i4L2 CLzC1Tk1tCjHPKu1despuE0sAVBcXHN+/2XYApg7SLjnqQsYnOM7MY46ySFwFUB2 qiyeIcA5c3RZqLIJjh8QWB8h1rQm2jLYS+Tl53G0zDsb/FHAPvS8SF0alkMHquYV xOe+rUc4eAAGd/cphI4kBNDLhEX/Mn9PbdmbBQXiKlQm37N0qhw= =plL0 -----END PGP SIGNATURE----- --=-ooQWMYcjy3Hf0Dcp6ivh--