Re: [gentoo-dev] Re: [BUG and PATCH] Does dcron need a space at the end of each

["Christian HOFFMANN" <christian.hoffmann@noos.fr>]

I tested your proposed modification, it works far better than mine.

I was just wrong in the beginning, my problem was lines starting with a 
space (for allignment purpose) and my patch break the others tasks on 
lines not starting with a space.

Now dcron work for lines starting or not with a space or tabs or...

For your information dcron2.7 is the standard cron for the Gentoo 
Linux distribution. http://www.gentoo.org

> 
> :I just fired gdb to find the source of this problem and found the source 
> :of the problem being at line 178 of database.c
> :
> :was: 			buf[strlen(ptr)-1] = 0;
> :is now on my system:	buf[strlen(ptr)] = 0;
> :
> :This line was chopping 2 char at the end of the line the last one of the 
> :command and the newline. You have to remove one char but indexing 
> :starts at 0 and strlen give the number of char.
> :
> :I'm new to patch submission, howto ?
> :
> :Regards
> 
>     Well, I do not know who is maintaining the linux version of dcron.
>     I maintain my master source but I don't think the linux sites are
>     picking it up.
> 
>     In regards to this bug, I think the problem is that it should be
>     'ptr[strlen(ptr)-1] = 0' rather then 'buf[strlen(ptr)-1] = 0'.
>     That is, it is trying to remove the newline at the end of the
>     buffer.  The bug occurs if you have spaces at the front of the line.
> 
>     Please try 'ptr[strlen(ptr)-1] = 0' and see if that solves your
>     problem.
> 
> 						-Matt
> 
> _______________________________________________
> gentoo-dev mailing list
> gentoo-dev@gentoo.org
> http://lists.gentoo.org/mailman/listinfo/gentoo-dev
> 

-----------------------------------------------
Christian HOFFMANN <christian.hoffmann@noos.fr>