From: Eli Schwartz <eschwartz93@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Reviewing ebuilds with git
Date: Sun, 30 Jun 2024 14:21:42 -0400 [thread overview]
Message-ID: <35d9c7d0-8d25-400b-97d2-6179ea424073@gmail.com> (raw)
In-Reply-To: <87r0cepbzs.fsf@gentoo.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1081 bytes --]
On 6/30/24 1:38 PM, Sam James wrote:
> Hi,
>
> I've mentioned this on IRC a bunch of times to people but I figure I'll
> mention it here in case anyone finds it useful.
>
> Our use of git doesn't lend itself well to the default mode `git diff`
> and friends operate in, as we create many new files rather than solely
> changing existing ones.
>
> git can be coerced into checking for copies (and doing so "harder" too)
> but there's no configuration option for this, and it's a pain to
> remember.
>
> You can use the attached patch for dev-vcs/git and then set:
> $ git config diff.renames copies-harder
> in gentoo.git to make `git log -p`, `git diff`, etc default to this
> mode.
>
> IME, it makes reviewing much easier. Be warned that it does make git log
> a bit slower though if the config option is enabled for a repo -- but
> maybe only noticeably if your repo is grafted with the pre-2015 CVS history.
Just to add: I think it helped a lot to make log -pC work faster, once I
set up `git commit-graph --changed-paths`.
--
Eli Schwartz
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2024-06-30 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 17:38 [gentoo-dev] Reviewing ebuilds with git Sam James
2024-06-30 18:21 ` Eli Schwartz [this message]
2024-06-30 19:18 ` Vitaly Zdanevich
2024-06-30 19:49 ` Martin Dummer
2024-07-01 6:25 ` Jaco Kroon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d9c7d0-8d25-400b-97d2-6179ea424073@gmail.com \
--to=eschwartz93@gmail.com \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox