[gentoo-dev] [PATCH] Add EAPI=8 support

[gentoo-dev] [PATCH] Add EAPI=8 support

[Conrad Kostecki]

Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
---
 eclass/cdrom.eclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
index bae3888c6c5..81539e8560c 100644
--- a/eclass/cdrom.eclass
+++ b/eclass/cdrom.eclass
@@ -1,10 +1,10 @@
-# Copyright 1999-2021 Gentoo Authors
+# Copyright 1999-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: cdrom.eclass
 # @MAINTAINER:
 # games@gentoo.org
-# @SUPPORTED_EAPIS: 6 7
+# @SUPPORTED_EAPIS: 6 7 8
 # @BLURB: Functions for CD-ROM handling
 # @DESCRIPTION:
 # Acquire CD(s) for those lovely CD-based emerges.  Yes, this violates
@@ -16,7 +16,7 @@
 # The functions are generally called in src_unpack.
 
 case ${EAPI:-0} in
-	[67]) ;;
+	6|7|8) ;;
 	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
 esac
 
-- 
2.35.1

Re: [gentoo-dev] [PATCH] Add EAPI=8 support

[Matt Turner]

Subject should be prefixed with "cdrom.eclass:"

Re: [gentoo-dev] [PATCH] Add EAPI=8 support

[James Le Cuirot]

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

On Sun, 2022-04-10 at 21:22 +0200, Conrad Kostecki wrote:
> Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
> ---
>  eclass/cdrom.eclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
> index bae3888c6c5..81539e8560c 100644
> --- a/eclass/cdrom.eclass
> +++ b/eclass/cdrom.eclass
> @@ -1,10 +1,10 @@
> -# Copyright 1999-2021 Gentoo Authors
> +# Copyright 1999-2022 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: cdrom.eclass
>  # @MAINTAINER:
>  # games@gentoo.org
> -# @SUPPORTED_EAPIS: 6 7
> +# @SUPPORTED_EAPIS: 6 7 8
>  # @BLURB: Functions for CD-ROM handling
>  # @DESCRIPTION:
>  # Acquire CD(s) for those lovely CD-based emerges.  Yes, this violates
> @@ -16,7 +16,7 @@
>  # The functions are generally called in src_unpack.
>  
>  case ${EAPI:-0} in
> -	[67]) ;;
> +	6|7|8) ;;
>  	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>  esac

That's fine, the commit message aside. There's nothing particularly API-
specific about this eclass.

On a sidenote, if all the consumers get bumped to EAPI 8 then we can revert
1e09cba657ccb2b8, which fixed the eclass for Bash 4.2 and 4.3, but made it a
tiny bit more complex. EAPI 8 requires Bash 5.0.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]