From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7ABC6158041 for ; Sun, 25 Feb 2024 20:55:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AE16DE29C8; Sun, 25 Feb 2024 20:55:23 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2EAC4E29C0 for ; Sun, 25 Feb 2024 20:55:23 +0000 (UTC) Message-ID: <2e39fb03-ab3f-43ae-8895-97920bb49694@gentoo.org> Date: Sun, 25 Feb 2024 21:55:21 +0100 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Matthias Schwarzott Subject: Re: [gentoo-dev] [PATCH 1/2] */*: Replace dependency to virtual/linuxtv-dvb-headers by sys-kernel/linux-headers Content-Language: en-GB, de-DE To: gentoo-dev@lists.gentoo.org, vdr@gentoo.org, martin.dummer@gmx.net, media-video@gentoo.org References: <20240213081947.16295-1-zzam@gentoo.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: cf352a78-9587-4d87-a162-e2f71f7b09ef X-Archives-Hash: e1b7093ed38fc5d8a386c0950c5ba941 Am 25.02.24 um 18:54 schrieb Ionen Wolkens: > On Tue, Feb 13, 2024 at 09:19:46AM +0100, Matthias Schwarzott wrote: >> virtual/linuxtv-dvb-headers has been important in the past when >> linux-headers was not yet up-to-date. >> Now it just pulls in >=sys-kernel/linux-headers-3.7. >> Even that could be dropped as it is part of @system. >> >> Bug: https://bugs.gentoo.org/924398 >> Signed-off-by: Matthias Schwarzott > >> diff --git a/media-video/mpv/mpv-0.37.0-r1.ebuild b/media-video/mpv/mpv-0.37.0-r1.ebuild >> index 731cc45c2106..9ce839af5283 100644 >> --- a/media-video/mpv/mpv-0.37.0-r1.ebuild >> +++ b/media-video/mpv/mpv-0.37.0-r1.ebuild >> @@ -116,7 +116,7 @@ RDEPEND=" >> DEPEND=" >> ${COMMON_DEPEND} >> X? ( x11-base/xorg-proto ) >> - dvb? ( virtual/linuxtv-dvb-headers ) >> + dvb? ( >=sys-kernel/linux-headers-3.7 ) > > Had missed this mail (sorry), not that I have much to say about it. > > I'd argue that there's no need to clutter ebuilds with the >=3.7 bit > at this point, <3.7 is long gone (dropped 9 years ago, and its addition > predates the tree's git migration). > > Think should keep the dependency itself though, it's not part of > @system on *all* profiles (virtual/os-headers has conditions esp. > with some prefixes). Similar deal to depending on glibc when packages > are prebuilt and cannot be used with musl so pkgcheck can warn if masks > are missing. I also wondered if I could drop the dependency completely. Then decided for the simplest possible solution. I will update it to only depend on linux-headers. Regards Matthias