From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C9A03158064 for ; Mon, 13 May 2024 14:02:47 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 786D7E2A93; Mon, 13 May 2024 14:02:44 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2BD7EE2A75 for ; Mon, 13 May 2024 14:02:44 +0000 (UTC) Message-ID: <2b970ab19a96daff31a34b5a1f9f468349bd362a.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: Optimize crate unpacking From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Mon, 13 May 2024 16:02:38 +0200 In-Reply-To: References: <20240512022603.48576-1-mgorny@gentoo.org> <6c25db91-4a22-48d5-b639-8009487fb7bf@gentoo.org> <849a540bd028ac0fed47c75c71ecf077f703c28d.camel@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-/cdt7RhZhexoQ1/4ZtVf" User-Agent: Evolution 3.52.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: e27b2219-aa8a-4fdb-813e-2504b94c7d04 X-Archives-Hash: 37609322581dab5f63d42dfdb64d3b1e --=-/cdt7RhZhexoQ1/4ZtVf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2024-05-13 at 16:00 +0200, Florian Schmaus wrote: > On 12/05/2024 20.21, Micha=C5=82 G=C3=B3rny wrote: > > On Sun, 2024-05-12 at 19:22 +0200, Florian Schmaus wrote: > > > On 12/05/2024 04.26, Micha=C5=82 G=C3=B3rny wrote: > > > > + if [[ ${PKGBUMPING} !=3D ${PVR} ]]; then > > > > + pushd "${DISTDIR}" >/dev/null || die > > > > + > > > > + ebegin "Unpacking crates" > > > > + printf '%s\0' "${crates[@]}" | > > > > + xargs -0 -P "$(makeopts_jobs)" -n 1 -- \ > > >=20 > > > Consider using get_makeopts_jobs instead of makeopts_jobs, as it > > > searches more variables for --jobs. > >=20 > > Whose bright idea was to add a second similarly named function that doe= s > > roughly the same thing but apparently differently? It can hardly get > > more confusing. >=20 > You are absolutely right, it sucks that we have two very similar methods. >=20 > You are invited to suggest how the situation can be improved. However,= =20 > rambling without presenting alternatives is not helpful in any way. >=20 My suggestion would be for the person who introduced new methods and implicitly claimed the old methods to be "legacy" to put an actual effort to migrate consumers. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-/cdt7RhZhexoQ1/4ZtVf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmZCHX8SHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOozAIALyLvLOQMUMrMnfqHX+3eZxo+5OjzRw8 1usAubpISZ0TXoxQL19BaYF2Z2cNvPO9eiHz770M1csJyvAxghSFCBwq2RhsC1nI b3Oql20hjZQc1gF+8ouavFg0F6TzmY9f0SMqmzhw6bkqKehIKySr7qRISTwsHUof RdYprSDVJPCaOOJI053Qq635sgcSsmLJqt1DftP/wOzIR0Zvvyyfg75KFVfvCTUX EhuC7trZg/VJhlXsfGK688e7HsBUS6t1uKcgvK+BY04t/SvOeIHtDDcJ8+xfGxcS r7HZh439CKIfu01+6ZlRSz70gOuS8ifUNIeJ+l7/LWRCYqUWWJHDMQg= =Ld05 -----END PGP SIGNATURE----- --=-/cdt7RhZhexoQ1/4ZtVf--