public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Anthony G. Basile" <blueness@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] Update toolchain.eclass to deal with .xz compressed tarball for gcc-6.4.0
Date: Wed, 2 Aug 2017 17:09:41 -0400	[thread overview]
Message-ID: <2777c976-b0b9-ee7c-deb1-fac9282bf679@gentoo.org> (raw)
In-Reply-To: <CAJ0EP43f6rvWSTit=9Lc8EY3RF2h2dHDGJRPzq0+RW=EXV76=Q@mail.gmail.com>

On 8/2/17 5:00 PM, Mike Gilbert wrote:
> On Wed, Aug 2, 2017 at 4:52 PM, Anthony G. Basile <blueness@gentoo.org> wrote:
>> Hi everyone,
>>
>> Upstream gnu.org used to provide .gz and .bz2 compressed tarballs for
>> gcc's source code.  With gcc-6.4.0 however, they only provide .gz and
>> .xz.  Our toolchain.eclass is written only for .bz2.  I'd like to commit
>> the attached patch to deal with this change.  A better fix would
>> autodetect whether upstream has .bz2 or .xz but I'm not sure how to
>> proceed with that.
> 
> Another option would be to move the SRC_URI setting code into the
> individual ebuilds, instead of setting it in the eclass.
> 

I would still have problems with the unpack which I can't override.



Also, [Arfrever] on IRC suggested that instead of

if tc_version_is_between 6.4.0 7 ;  then

I use

if tc_version_is_between 5.5 6 || tc_version_is_between 6.4 7 ||
tc_version_is_at_least 7.2 ; then

to better future proof the code.  The assumption here being that gnu.org
will continue using .xz instead of .bz2 going forward which seems
reasonable.

-- 
Anthony G. Basile, Ph.D.
Gentoo Linux Developer [Hardened]
E-Mail    : blueness@gentoo.org
GnuPG FP  : 1FED FAD9 D82C 52A5 3BAB  DC79 9384 FA6E F52D 4BBA
GnuPG ID  : F52D4BBA


      reply	other threads:[~2017-08-02 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 20:52 [gentoo-dev] [RFC] Update toolchain.eclass to deal with .xz compressed tarball for gcc-6.4.0 Anthony G. Basile
2017-08-02 21:00 ` Mike Gilbert
2017-08-02 21:09   ` Anthony G. Basile [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2777c976-b0b9-ee7c-deb1-fac9282bf679@gentoo.org \
    --to=blueness@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox