From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2BFD2158041 for ; Fri, 29 Mar 2024 14:17:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8924DE2A7D; Fri, 29 Mar 2024 14:17:20 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DE1F5E2A7A for ; Fri, 29 Mar 2024 14:17:19 +0000 (UTC) Message-ID: <27115d568ede626500b05af5afaa54b39916f948.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 29 Mar 2024 15:17:15 +0100 In-Reply-To: <20240329035439.11381-1-eschwartz93@gmail.com> References: <20240329035439.11381-1-eschwartz93@gmail.com> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-7YPlzqSu3SNUfEVfubKd" User-Agent: Evolution 3.50.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 9ca2d6b7-7bf6-4d8f-9039-40867ec36be7 X-Archives-Hash: 0d0ec4b081effecb530f24f71506450f --=-7YPlzqSu3SNUfEVfubKd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2024-03-28 at 23:54 -0400, Eli Schwartz wrote: > * QA Notice: The ebuild is installing to one or more unexpected paths: > * > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_f= iles > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_ex= amples > * > * Please fix the ebuild to use correct FHS/Gentoo policy paths. >=20 > This message is hard to understand. Is it saying that the resulting > package contains files prefixed with ${D} which would be immensely > broken? Is it saying that these paths are *directories* and the FHS does > not approve of directories in /usr/bin/*/? >=20 > In fact, it's the latter. Fix this in two ways: >=20 > - clarify that it's an unexpected directory, not just some kind of path >=20 > - strip ${D} so that people can better visualize what sort of path gets > installed. This has the downside of not being able to copy/paste the > path in order to inspect the image directory, but I think this is a > very small downside. Usually by the time you see this message, portage > has cleaned up. And if it hasn't, you can still copy/paste that from: >=20 > Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-= cluster/legion-9999/image >=20 > Signed-off-by: Eli Schwartz > --- > metadata/install-qa-check.d/08gentoo-paths | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/metadata/install-qa-check.d/08gentoo-paths b/metadata/instal= l-qa-check.d/08gentoo-paths > index 5b8607fd5f96..0b92a7a1c132 100644 > --- a/metadata/install-qa-check.d/08gentoo-paths > +++ b/metadata/install-qa-check.d/08gentoo-paths > @@ -70,9 +70,9 @@ gentoo_path_check() { > # report > # ------ > if [[ -n ${bad_paths[@]} ]]; then > - eqawarn "QA Notice: The ebuild is installing to one or more unexpected= paths:" > + eqawarn "QA Notice: The ebuild is installing to one or more unexpected= directories:" > eqawarn > - eqatag -v non-gentoo-paths "${bad_paths[@]}" > + eqatag -v non-gentoo-paths "${bad_paths[@]#${D%/}}" > eqawarn > eqawarn "Please fix the ebuild to use correct FHS/Gentoo policy paths.= " > fi LGTM. Thanks! --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-7YPlzqSu3SNUfEVfubKd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmYGzWsSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOz3UIAK2FOp4TpYOfRMLdTqaZJcFxSiDWndDe YoATKMa2O84S9CUzq9LaHC/mi+NqPeiIP6KPAoqboKVm/4g0xfHaeoAUxNte+2yJ nSkO6ZH3WGvAY9sDwTX3LfvVoKCalvIGT/dr16qhGsbFAIA01KveUpv/r0Mhxt/i Y9jEndn8cGSQkpYdy5WRL/p/fYgDD0GSDDpvokgtD7twDcTbVs7NgFEO6W7vX4WJ q92GOAdAMn38Ybu/97y4hNAyC2BtXp+W7jn0oFHlLqANdT7hbziQpMDzVS6mwRpS 120gJrtqZG0Fo39/nogt/YpoivA5o/p6kA4PJsZLToeA8Xvj4Lnk8Co= =8uZl -----END PGP SIGNATURE----- --=-7YPlzqSu3SNUfEVfubKd--