[gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0

[gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0

[Marek Szuba]

[-- Attachment #1.1.1: Type: text/plain, Size: 11 bytes --]


-- 
MS

[-- Attachment #1.1.2: 2017-04-24-burp2-default-bedup-config.en.txt --]
[-- Type: text/plain, Size: 704 bytes --]

Title: app-backup/burp: default config file for bedup
Author: Marek Szuba <marecki@gentoo.org>
Posted: 2017-04-24
Revision: 1
News-Item-Format: 2.0
Display-If-Installed: app-backup/burp

Starting with version 2.0.54, the default configuration file of the
burp-aware deduplication tool bedup will change from

  /etc/burp/burp-server.conf

to

  /etc/burp/burp.conf .

The latter is the value used by upstream and with burp2 bedup being
a part of the main executable rather than a standalone tool,
maintaining old Gentoo behaviour would needlessly complicate the code.

If you want to keep using burp-server.conf with bedup, you can specify
it on the command line:

  bedup -c /etc/burp/burp-server.conf


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0

[Gokturk Yuksek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

> Display-If-Installed: app-backup/burp

Wouldn't you wanna limit this to <2.0.54 ? Otherwise this will pop up
for the consumers of 2.0.54 as well.

> /etc/burp/burp.conf .

You have an extra '.' at the end.

> maintaining old Gentoo behaviour would needlessly complicate the
> code.

I think upstream using the new path is enough justification, do you
really need to justify it any further?

> If you want to keep using burp-server.conf with bedup, you can
> specify it on the command line:
> 
> bedup -c /etc/burp/burp-server.conf

Maybe it's better to also provide a one-liner of 'mv' for people who
just want to upgrade to the new path.

Overall, my impression is that people handle conf file changes in
pkg_postinst() with REPLACING_VERSIONS rather than news items. How fatal
are the consequences of not updating the conf file path? Would the
program abort or misbehave?

- --
gokturk

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEv2SYNjDGGh+3Be4QhPgC5cCIzjMFAlj3hIoACgkQhPgC5cCI
zjObuQf/fu6L0fhJU/C2jW1D2th3xD9UaB2/1n/Ow/9dAYU71JnB+FFkzGdRxEW+
O4/dN9FiY46rnetAuA4JjFHq4HovBslwnxunPOwVLTOfjPUuKcHSN1yEwdxRUBQH
MQFvSSmDqJ9kzoohRz2W+5ZDTCrl0qmxIs8tVeOV5mazIP6X6QuSkOHI6UkgqkMt
xnFJDHfLwCwWL63yQV67fCh72b8UcMQRnVJxysBkUjzL0ppRSX/4ZI1g5CAVFSdk
phKoUZgIVMunCs0eWgj5H6pXSyvcklMcRib+pQHB65GPPpMKkde4LNoyx6O8Mxa/
xa8rSUmxq35c42JpncTjPdSj4bmJzg==
=Qvh/
-----END PGP SIGNATURE-----

Re: [gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0

[Amadeusz Żołnowski]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

Gokturk Yuksek <gokturk@gentoo.org> writes:
> Overall, my impression is that people handle conf file changes in
> pkg_postinst() with REPLACING_VERSIONS rather than news items.

+1. And it could be automated for the user, couldn't be?

Cheers,
-- Amadeusz Żołnowski

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 980 bytes --]

Re: [gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0

[Marek Szuba]

[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]

On 2017-04-19 17:39, Gokturk Yuksek wrote:

>> Display-If-Installed: app-backup/burp
> Wouldn't you wanna limit this to <2.0.54 ? Otherwise this will pop
> up for the consumers of 2.0.54 as well.
Might as well, although at present there is no 2.0.54.

>> /etc/burp/burp.conf .
> You have an extra '.' at the end.
Yes, it's a full stop at the end of the sentence. Come to think of it it
looks confusing though, I'll remove it.

> I think upstream using the new path is enough justification, do you 
> really need to justify it any further?
It's not like that. Upstream has always used $sysconfdir/burp.conf , by
default however that file provides client-mode configuration and bedup
refuses to run unless it is pointed to a server-mode config file. Making
bedup use $sysconfig/burp-server.conf by default is achieved in burp-1
ebuilds through the means of a Gentoo patch.

> Maybe it's better to also provide a one-liner of 'mv' for people who 
> just want to upgrade to the new path.
It is not the matter of the config file having been renamed, burp has
always come with both burp.conf and burp-server.conf.

> Overall, my impression is that people handle conf file changes in 
> pkg_postinst() with REPLACING_VERSIONS rather than news items.
See above.

> How fatal are the consequences of not updating the conf file path?
> Would the program abort or misbehave?
Abort. Please note however that in a typical production scenario bedup
would be run periodically by cron or a similar tool, i.e. without admin
intervention, meaning that for everyone who doesn't review their logs
carefully backup deduplication would simply quietly stop working.

-- 
MS


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]