public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Marek Szuba <marecki@gentoo.org>
To: gentoo-dev@lists.gentoo.org, pr@gentoo.org
Subject: Re: [gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0
Date: Thu, 20 Apr 2017 10:10:21 +0200	[thread overview]
Message-ID: <2654f4b4-d751-9346-83d6-33ab29f35318@gentoo.org> (raw)
In-Reply-To: <94a1248a-38d4-28ba-8b14-4a844cfad3b2@gentoo.org>


[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]

On 2017-04-19 17:39, Gokturk Yuksek wrote:

>> Display-If-Installed: app-backup/burp
> Wouldn't you wanna limit this to <2.0.54 ? Otherwise this will pop
> up for the consumers of 2.0.54 as well.
Might as well, although at present there is no 2.0.54.

>> /etc/burp/burp.conf .
> You have an extra '.' at the end.
Yes, it's a full stop at the end of the sentence. Come to think of it it
looks confusing though, I'll remove it.

> I think upstream using the new path is enough justification, do you 
> really need to justify it any further?
It's not like that. Upstream has always used $sysconfdir/burp.conf , by
default however that file provides client-mode configuration and bedup
refuses to run unless it is pointed to a server-mode config file. Making
bedup use $sysconfig/burp-server.conf by default is achieved in burp-1
ebuilds through the means of a Gentoo patch.

> Maybe it's better to also provide a one-liner of 'mv' for people who 
> just want to upgrade to the new path.
It is not the matter of the config file having been renamed, burp has
always come with both burp.conf and burp-server.conf.

> Overall, my impression is that people handle conf file changes in 
> pkg_postinst() with REPLACING_VERSIONS rather than news items.
See above.

> How fatal are the consequences of not updating the conf file path?
> Would the program abort or misbehave?
Abort. Please note however that in a typical production scenario bedup
would be run periodically by cron or a similar tool, i.e. without admin
intervention, meaning that for everyone who doesn't review their logs
carefully backup deduplication would simply quietly stop working.

-- 
MS


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2017-04-20  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 14:18 [gentoo-dev] News item: changed default bedup configuration file in >=app-backup/burp-2.0.0 Marek Szuba
2017-04-19 15:39 ` Gokturk Yuksek
2017-04-19 19:55   ` Amadeusz Żołnowski
2017-04-20  8:10   ` Marek Szuba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2654f4b4-d751-9346-83d6-33ab29f35318@gentoo.org \
    --to=marecki@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=pr@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox