From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-73367-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 6994F1384B4
	for <garchives@archives.gentoo.org>; Sat, 28 Nov 2015 14:04:12 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 4AD5421C0BE;
	Sat, 28 Nov 2015 14:04:06 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 22C0621C023
	for <gentoo-dev@lists.gentoo.org>; Sat, 28 Nov 2015 14:04:05 +0000 (UTC)
Received: from [10.203.176.70] (public-gprs516800.centertel.pl [31.61.138.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: mgorny)
	by smtp.gentoo.org (Postfix) with ESMTPSA id 7836F3406C0;
	Sat, 28 Nov 2015 14:03:52 +0000 (UTC)
User-Agent: K-9 Mail for Android
In-Reply-To: <1448717061-11581-5-git-send-email-jlec@gentoo.org>
References: <1448717061-11581-1-git-send-email-jlec@gentoo.org> <1448717061-11581-5-git-send-email-jlec@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Subject: Re: [gentoo-dev] [PATCH 4/8] virtualx.eclass: Ban deprecated functionality in EAPI > 5
From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= <mgorny@gentoo.org>
Date: Sat, 28 Nov 2015 15:03:31 +0100
To: gentoo-dev@lists.gentoo.org,Justin Lecher <jlec@gentoo.org>
CC: Justin Lecher <jlec@gentoo.org>
Message-ID: <2647371C-3C43-4282-850C-EEAA27A61FCD@gentoo.org>
X-Archives-Salt: 0143ac27-0fbf-4250-835a-b2ccde51e81e
X-Archives-Hash: d3a604c4ff9af6cb171d99ffda6d4c2b



Dnia 28 listopada 2015 14:24:17 CET, Justin Lecher <jlec@gentoo.org> napisał(a):
>Signed-off-by: Justin Lecher <jlec@gentoo.org>
>---
> eclass/virtualx.eclass | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
>index a7f17ec..615ff0e 100644
>--- a/eclass/virtualx.eclass
>+++ b/eclass/virtualx.eclass
>@@ -59,6 +59,7 @@ case ${VIRTUALX_REQUIRED} in
> 		RDEPEND=""
> 		;;
> 	optional|tests)
>+		[[ ${EAPI} == [2345] ]] || die 'Values "optional" and "tests" are
>unsupported for VIRTUALX_REQUIRED'

You can now make eutils conditional to EAPI.

> 		# deprecated section YAY.
>		eqawarn "VIRTUALX_REQUIRED=optional and VIRTUALX_REQUIRED=tests are
>deprecated."
>		eqawarn "You can drop the variable definition completely from
>ebuild,"
>@@ -177,6 +178,9 @@ virtualmake() {
> Xmake() {
> 	debug-print-function ${FUNCNAME} "$@"
> 
>+	[[ ${EAPI} == [2345] ]] \
>+		|| die "${FUNCNAME} is removed in EAPI > 5; use Xemake -j1 instead"
>+
> 	eqawarn "you should not execute make directly"
>	eqawarn "rather execute Xemake -j1 if you have issues with parallel
>make"
> 	VIRTUALX_COMMAND="emake -j1" virtualmake "$@"

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.