From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9024F158066 for ; Tue, 3 Sep 2024 07:24:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5BAB6E2A03; Tue, 3 Sep 2024 07:24:17 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1B467E29FD for ; Tue, 3 Sep 2024 07:24:17 +0000 (UTC) Message-ID: <26471b96faab4e3b61ce29622415215854f17314.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 03 Sep 2024 09:24:11 +0200 In-Reply-To: <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org> References: <20240825153341.21121-1-mgorny@gentoo.org> <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-v0YmJO7CHjeycCUiB8V+" User-Agent: Evolution 3.52.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 3ff124ce-e44c-45dc-904e-67681f9a6461 X-Archives-Hash: 8e04dc3ae0b66f2a912fd562dd10a885 --=-v0YmJO7CHjeycCUiB8V+ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2024-08-25 at 11:36 -0400, Eli Schwartz wrote: > On 8/25/24 11:33 AM, Micha=C5=82 G=C3=B3rny wrote: > > Closes: https://bugs.gentoo.org/937642 > > Signed-off-by: Micha=C5=82 G=C3=B3rny > > --- > > eclass/distutils-r1.eclass | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > > index 0f9dc8d14d5e..39705c5c3c84 100644 > > --- a/eclass/distutils-r1.eclass > > +++ b/eclass/distutils-r1.eclass > > @@ -2109,8 +2109,10 @@ _distutils-r1_post_python_install() { > > local strays=3D() > > local p > > mapfile -d $'\0' -t strays < <( > > + # jar for jpype, https://bugs.gentoo.org/937642 > > find "${sitedir}" -maxdepth 1 -type f '!' '(' \ > > -name '*.egg-info' -o \ > > + -name '*.jar' -o \ > > -name '*.pth' -o \ > > -name '*.py' -o \ > > -name '*.pyi' -o \ >=20 >=20 > Copying my comment from the bug report: >=20 > I don't think it makes sense to add a special exception for jar files. > If we think that packages may be legitimately storing *data* files at > the top level, we should either relax the check in general, or allow > adding a suppression variable for packages to suppress this check. >=20 If you don't like JPype's design decisions, take it up to them. This is not my fight. This is the simplest solution to the problem at hand. The check is primarily supposed to detect obvious violations, such as common Poetry use screwups that install random documentation and package configuration files (LICENSE, README, pyproject.toml...) there. I don't see a point in adding a lot of complexity for theoretical purity. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-v0YmJO7CHjeycCUiB8V+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmbWuZwSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOhUYH/1EVPl3AW3Uu3mh9u8s5RI9YA6XXGuTQ yXSxCOqLH2cRcCtz+tL3e4O4O6gbbuZtY5xi8HA9goy1hefUNzByswGA+LO0pJEA jqTOqN6gxnf8UNFzrwohl/r6osrXvhkux/5dtKA5htmnGionci1i7UXLtvSiKu83 wYo0eds5uPUJMcpuokX1DWucspHMmfOeOcoGA/JpUnb65Gg1mh5LM5iEGmNjeM2N QD3gchgnnxXWugNKQhdKx069oAKAglZ4Oonwczz6JuXf1tZ3QaP4yTXJ4YAmPz6N Bda6TDjcRUYHqoQ/gv6zXZK59TD2CNm2STQ0+4hD25OCpMZZRJ/Az7g= =qZkt -----END PGP SIGNATURE----- --=-v0YmJO7CHjeycCUiB8V+--