From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E9D4A1581D3 for ; Wed, 22 May 2024 03:38:41 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 98415E2A47; Wed, 22 May 2024 03:38:37 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 01291E2A3D for ; Wed, 22 May 2024 03:38:36 +0000 (UTC) Message-ID: <246638361b9afd85bcb42aad0f710a29e1b773a2.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: Mike Gilbert Date: Wed, 22 May 2024 05:38:31 +0200 In-Reply-To: <20240522020519.1845786-1-floppym@gentoo.org> References: <20240522015830.1841810-1-floppym@gentoo.org> <20240522020519.1845786-1-floppym@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-QjU+/SBDK6/c+TlNiw8t" User-Agent: Evolution 3.52.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 9d736a75-ec35-43c8-8542-8a0c894e7738 X-Archives-Hash: 4764ef7d01db88fd5616ce12fc459a95 --=-QjU+/SBDK6/c+TlNiw8t Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2024-05-21 at 22:05 -0400, Mike Gilbert wrote: > Signed-off-by: Mike Gilbert > --- > eclass/verify-sig.eclass | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass > index b74ed78290aa..4d48c9ed8503 100644 > --- a/eclass/verify-sig.eclass > +++ b/eclass/verify-sig.eclass > @@ -426,10 +426,14 @@ verify-sig_src_unpack() { > verify-sig_verify_detached \ > "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}" > done > - fi > =20 > - # finally, unpack the distfiles > - default_src_unpack > + # finally, unpack the distfiles > + if [[ ${#distfiles[@]} -gt 0 ]]; then > + unpack "${distfiles[@]}" > + fi > + else > + default_src_unpack > + fi > } > =20 > fi Please make a pull request or send a patch with more context. As submitted, this patch is completely unreadable. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-QjU+/SBDK6/c+TlNiw8t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmZNaLcSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQO8wsH/i2Csiix1d4JQAAeaB8KT2TPcurBTrn2 GW2V6UHQqfE539pdwB8mZeAVy4oGEasLljczBd4LQdl+ZjG8J8pIKjtZa9l7z1rr xa83cPya7QIclKbjbdpBgU0eUBsFVaR6HzCgcn1199rtMtF7nw/RqevsJVgY7KgN XxA8EIxvnKf0HMR1TvAKOaD9KEuH16V5wf6tBLYwxDxZDh4ndqob10ZEy/Zb+Mjv PWvSU+TTwzhLUDPggaOIRlWMNbTAfauWBYRgCcY+v6JVoCGyWLA1Xz+LeibDJxae iaj6UlP++zEzkjie/dfdY3F89u4PzVV+Zc37Eqqz7D3cIC/zNFVCl+Q= =80Ro -----END PGP SIGNATURE----- --=-QjU+/SBDK6/c+TlNiw8t--