From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5CF3A159C96 for ; Thu, 25 Jul 2024 09:47:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0FDC4E2A77; Thu, 25 Jul 2024 09:47:53 +0000 (UTC) Received: from tauri.iewc.co.za (tauri.iewc.co.za [154.73.32.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C0F44E2A10 for ; Thu, 25 Jul 2024 09:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=uls.co.za; s=20240625.tauri; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qdAFdDlWpG1OhzCtZT5GVNFsy3voe9IMZPkkIHzrt7s=; b=Np41kx3SM9PhNSwRwbsgfERud3 nOofqI/S3VfSge1hpL7uRVlcMJh/wvS0vVTVzdP+7ScNXY/WBU3WQNtDRpBpOW4qtS+7ooeIVJaI/ dHVCqJlHkcCLjsaLMPI1lC0SczJmpY1Sda4ajlQkIHEwG978cxKzsumCn1NQCbq+uETlazkHFptgq UOFYaohjpc9oauNt8gBgS9tS6Smn9Kc8iX7fg5wlaKzJYToj5MOlkWEeeV0ChaLlKXQZg21iDStL2 MQMg1FOxxyMVFwKLXYi+W/QhvtxE7f3TQhi/INUBGTQkWndZutXT1OStIvng8o6V6GS0xHRNjGBQw ParHzuzQ==; Received: from [192.168.42.21] by tauri.iewc.co.za with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.97.1) (envelope-from ) id 1sWv4f-000000003JR-1a8G for gentoo-dev@lists.gentoo.org; Thu, 25 Jul 2024 11:47:49 +0200 Message-ID: <2462a5d1-e03e-40be-8049-6251dafb5e3a@uls.co.za> Date: Thu, 25 Jul 2024 11:47:47 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH] php-ext-source-r3.eclass: Rebuild exts should dev-lang/php[threads,debug] change. To: gentoo-dev@lists.gentoo.org References: <20240723104244.8432-1-jaco@uls.co.za> Content-Language: en-GB From: Jaco Kroon Autocrypt: addr=jaco@uls.co.za; keydata= xsBNBFXtplYBCADM6RTLCOSPiclevkn/gdf8h9l+kKA6N+WGIIFuUtoc9Gaf8QhXWW/fvUq2 a3eo4ULVFT1jJ56Vfm4MssGA97NZtlOe3cg8QJMZZhsoN5wetG9SrJvT9Rlltwo5nFmXY3ZY gXsdwkpDr9Y5TqBizx7DGxMd/mrOfXeql57FWFeOc2GuJBnHPZQMJsQ66l2obPn36hWEtHYN gcUSPH3OOusSEGZg/oX/8WSDQ/b8xz1JKTEgcnu/JR0FxzjY19zSHmbnyVU+/gF3oeJFcEUk HvZu776LRVdcZ0lb1bHQB2K9rTZBVeZLitgAefPVH2uERVSO8EZO1I5M7afV0Kd/Vyn9ABEB AAHNG0phY28gS3Jvb24gPGphY29AdWxzLmNvLnphPsLAdwQTAQgAIQUCVe2mVgIbAwULCQgH AgYVCAkKCwIEFgIDAQIeAQIXgAAKCRAILcSxr/fungCPB/sHrfufpRbrVTtHUjpbY4bTQLQE bVrh4/yMiKprALRYy0nsMivl16Q/3rNWXJuQ0gR/faC3yNlDgtEoXx8noXOhva9GGHPGTaPT hhpcp/1E4C9Ghcaxw3MRapVnSKnSYL+zOOpkGwye2+fbqwCkCYCM7Vu6ws3+pMzJNFK/UOgW Tj8O5eBa3DiU4U26/jUHEIg74U+ypYPcj5qXG0xNXmmoDpZweW41Cfo6FMmgjQBTEGzo9e5R kjc7MH3+IyJvP4bzE5Paq0q0b5zZ8DUJFtT7pVb3FQTz1v3CutLlF1elFZzd9sZrg+mLA5PM o8PG9FLw9ZtTE314vgMWJ+TTYX0kzsBNBFXtplYBCADedX9HSSJozh4YIBT+PuLWCTJRLTLu jXU7HobdK1EljPAi1ahCUXJR+NHvpJLSq/N5rtL12ejJJ4EMMp2UUK0IHz4kx26FeAJuOQMe GEzoEkiiR15ufkApBCRssIj5B8OA/351Y9PFore5KJzQf1psrCnMSZoJ89KLfU7C5S+ooX9e re2aWgu5jqKgKDLa07/UVHyxDTtQKRZSFibFCHbMELYKDr3tUdUfCDqVjipCzHmLZ+xMisfn yX9aTVI3FUIs8UiqM5xlxqfuCnDrKBJjQs3uvmd6cyhPRmnsjase48RoO84Ckjbp/HVu0+1+ 6vgiPjbe4xk7Ehkw1mfSxb79ABEBAAHCwF8EGAEIAAkFAlXtplYCGwwACgkQCC3Esa/37p7u XwgAjpFzUj+GMmo8ZeYwHH6YfNZQV+hfesr7tqlZn5DhQXJgT2NF6qh5Vn8TcFPR4JZiVIkF o0je7c8FJe34Aqex/H9R8LxvhENX/YOtq5+PqZj59y9G9+0FFZ1CyguTDC845zuJnnR5A0lw FARZaL8T7e6UGphtiT0NdR7EXnJ/alvtsnsNudtvFnKtigYvtw2wthW6CLvwrFjsuiXPjVUX 825zQUnBHnrED6vG67UG4z5cQ4uY/LcSNsqBsoj6/wsT0pnqdibhCWmgFimOsSRgaF7qsVtg TWyQDTjH643+qYbJJdH91LASRLrenRCgpCXgzNWAMX6PJlqLrNX1Ye4CQw== Organization: Ultimate Linux Solutions (Pty) Ltd In-Reply-To: <20240723104244.8432-1-jaco@uls.co.za> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: a16219d0-f6fc-423c-bdaf-02133e358c76 X-Archives-Hash: af37f844ddcc536216b04b4a1f374bf9 Based on no feedback I proceeded to push a PR available here: https://github.com/gentoo/gentoo/pull/37712 On 2024/07/23 12:42, Jaco Kroon wrote: > If these use flags change then the extension dir changes too, requiring > extensions to be rebuilt. > > The downside of this change is that different versions of PHP can no > longer have different USE values for threads and debug. > > Signed-off-by: Jaco Kroon > --- > eclass/php-ext-source-r3.eclass | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/eclass/php-ext-source-r3.eclass b/eclass/php-ext-source-r3.eclass > index 0d58db5031c9..771481ca7d3d 100644 > --- a/eclass/php-ext-source-r3.eclass > +++ b/eclass/php-ext-source-r3.eclass > @@ -100,6 +100,11 @@ esac > # php_targets_php7-0? ( dev-lang/php:7.0[mysql?,pdo,pcre(+)] ) > # @CODE > > +# Whenever certain PHP USE flags change, we need to also rebuild all > +# extensions. > +IUSE+="threads debug" > +[ -n "${PHP_EXT_NEEDED_USE}" ] && PHP_EXT_NEEDED_USE+=, > +PHP_EXT_NEEDED_USE+=threads=,debug= > > # Make sure at least one target is installed. First, start a USE > # conditional like "php?", but only when PHP_EXT_OPTIONAL_USE is > @@ -113,9 +118,7 @@ for _php_target in ${USE_PHP}; do > REQUIRED_USE+="php_targets_${_php_target} " > _php_slot=${_php_target/php} > _php_slot=${_php_slot/-/.} > - if [[ ${PHP_EXT_NEEDED_USE} ]] ; then > - _php_slot+=[${PHP_EXT_NEEDED_USE}] > - fi > + _php_slot+=[${PHP_EXT_NEEDED_USE}] > PHPDEPEND+=" php_targets_${_php_target}? ( dev-lang/php:${_php_slot} )" > done >