From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 372C7138216 for ; Mon, 2 May 2016 16:07:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03C6621C036; Mon, 2 May 2016 16:06:53 +0000 (UTC) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E570521C024 for ; Mon, 2 May 2016 16:06:51 +0000 (UTC) Received: by mail-lf0-f67.google.com with SMTP id p64so27658727lfg.0 for ; Mon, 02 May 2016 09:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version; bh=OSxJt1v4lld6xPWzB1SAS/2Lf69OUy9Zqb/1gxSsYJs=; b=ovwCPuR8rbQjBYUjN5xWqaVepWPVg7Y73fHmatdf193kUImkeXIDDAdbWscMkRtK88 2ZVmLDls8l9rDiWMvOiqzw+RytiCefVplLZkgC9Iv5VSzGyFetjAkr1i4qpP5bhUEKe7 aaxJ0nNIj6tGFpLnDIoQCAFogD+IS5ztOxcQFQ8PShKW0oHfUkLPiO8wg7lqHWxSZLEo +74DSBxquS/1hq8hu9xADXOa79v4zSnUhBUwqmJMWNUNQNMtnsdGMWts/nZrFASXF+cq cv03SkPW8ZOCJy688Wo+/y8SFrdJ567w1NaMryQqTvyjpWTilWMucdzPFUZGMZJHEki1 aUVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=OSxJt1v4lld6xPWzB1SAS/2Lf69OUy9Zqb/1gxSsYJs=; b=hjktMLCdmoQwp8R1CCUMidoBbGBhEyd0o4GZyUwdsRP5OodvaFEMQ8VPpJ63NWSEEp itSchwJdNw1NjoSizbwploRsl82WpK1QeFuDMEo3QmlQm2V2U0fWU/Un9PKVZ9dDyWPd Rzwu8wIJmne9omNbYYZvoWWPnv1UElDln+UpvgqHxrfRx6XQDnLszgSh9ar8W/tZTn3B yOxDnozWYlTkUGQJxEmdQr+AEr8N1sgnG4akN6xeA7LxFT3hybTND5lBb4/m/bSNJ1Q5 FQ3z7IG0IsZyPvekPpEK/7+irRGjib9/1wbLU2rk2y/ccUKWHtC9/rA+jQigJhSrA7/+ dsYA== X-Gm-Message-State: AOPr4FWKNid1Hf3M1/l/WubRm3Qb4uRPFxQmN03+GUXCmhR/B/bw9YKl50G+oxz/jKokTw== X-Received: by 10.25.20.155 with SMTP id 27mr12377717lfu.90.1462205210229; Mon, 02 May 2016 09:06:50 -0700 (PDT) Received: from liwardyna.localnet (90-156-71-188.internetia.net.pl. [90.156.71.188]) by smtp.gmail.com with ESMTPSA id rs2sm4308092lbb.33.2016.05.02.09.06.48 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 May 2016 09:06:49 -0700 (PDT) From: Maciej Mrozowski To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] [RFC] Enable CMAKE_WARN_UNUSED_CLI by default in cmake-utils for EAPI>=6 Date: Mon, 02 May 2016 18:06:44 +0200 Message-ID: <2425813.40BMEBc0ED@liwardyna> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.19; x86_64; ; ) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1642351.89vtLV0ZAx"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Archives-Salt: 53d3e6eb-4ffc-48c8-8d53-e6352b10805e X-Archives-Hash: f53b41bff614b8a13e56acb3046d72bc --nextPart1642351.89vtLV0ZAx Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Hello, General advise: do not convert ebuilds inheriting cmake-utils to EAPI 6 unless you know what you are doing (you are fully aware of eclass behaviour removed with https://bugs.gentoo.org/show_bug.cgi?id=514384). Background: Pre EAPI-6 cmake-utils.eclass contained certain feature to mitigate CMake variable case changes done by upstream. This feature was explicitly removed with https://bugs.gentoo.org/show_bug.cgi?id=514384 and no alternative was proposed. It opened new area of possible ebuild regression bugs when switching to EAPI-6 for ebuilds inheriting cmake-utils.eclass. Unfortunately there is common misconception, also among developers, that it's sufficient to simply replace "${cmake-utils_use_with foo)" with "-DWITH_foo=ON" etc. This is MOST OF THE TIME not the case. When converting cmake-utils ebuild to EAPI>=6, one needs to consult CMakeLists.txt wrt case each variable is written with since CMake is case- sensitive and WITH_FOO != WITH_foo != WITH_Foo. Proposal: CMake allows warning about unused CMake variables passed by CLI. Since this is how Gentoo passes ebuild configuration options, it's proposed to enable this feature. Unfortunately it won't fail compilation but at least it gives a chance to spot case mismatch when reading build output. Future thoughts: For better damage control it's technically possible to extend configure phase of cmake-utuls eclass to check mycmakeargs against parsed package buildsystem but this might not be very reliable. regards MM --nextPart1642351.89vtLV0ZAx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlcnexYACgkQFuHa/bHpVdu3TwCbBlQ47XRzq+TqmsXsATmNur7t L9IAoJoIQcF5NOE/qb+X5T7PBg91M2UQ =FH/T -----END PGP SIGNATURE----- --nextPart1642351.89vtLV0ZAx--