From: Jaco Kroon <jaco@uls.co.za>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.
Date: Mon, 9 Dec 2019 14:28:26 +0200 [thread overview]
Message-ID: <23dbe3d6-2c0c-7b73-0ceb-7ffe06f67a7d@uls.co.za> (raw)
In-Reply-To: <w6go8wh1ztb.fsf@kph.uni-mainz.de>
Hi,
>> What about just checking "${EROOT}/boot" instead?
> For what, existence? There may well be a "boot" directory present under
> EROOT. (And we could check ${EROOT}/etc/fstab, but I don't think we
> should open that can of worms. There's no reliable way to guess the
> user's exact configuration for non-trivial ROOT.)
I was hoping there is a somewhat reliable way ... but if not I guess as
is will be the best we can do.
IMHO: Ship it.
Even if there is issues still, the new state will be better than current.
Kind Regards,
Jaco
next prev parent reply other threads:[~2019-12-09 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 9:10 [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it Ulrich Müller
2019-12-07 13:39 ` Thomas Deutschmann
2019-12-07 16:02 ` Ulrich Mueller
2019-12-09 10:42 ` Jaco Kroon
2019-12-09 11:52 ` Ulrich Mueller
2019-12-09 12:28 ` Jaco Kroon [this message]
2019-12-11 6:08 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23dbe3d6-2c0c-7b73-0ceb-7ffe06f67a7d@uls.co.za \
--to=jaco@uls.co.za \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox