From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id D75FD13879D for ; Thu, 31 Jan 2013 15:22:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2E5D2E0678; Thu, 31 Jan 2013 15:22:21 +0000 (UTC) Received: from mail-ye0-f169.google.com (mail-ye0-f169.google.com [209.85.213.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3CA47E0653 for ; Thu, 31 Jan 2013 15:22:20 +0000 (UTC) Received: by mail-ye0-f169.google.com with SMTP id l13so602997yen.14 for ; Thu, 31 Jan 2013 07:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ICslp11qM7WdDQtmKElN9RGcDK9+e+NyGA6VyFINBzU=; b=GkZkMFgM3CrkUjs3VtAI0icqs/6KX36HjEgkwhIymlyCUtu6KV/IRvsqSveP+tbNcm CMeJ3fQTt2K9Iuhyu3ZJdJDV1MXfXNkUUg7EsWxgIo3SF6lB8pU1v1ofrb1bka7iavKr o8jBdo+S6a8F65ktCgUF/RVeUfgbWYvZeEAhhQHu90VIc6VMvoiGQBTX7E2LtnsnlTbz qgXeqL6059t75ybQtsThAXufhglQpvDXJuOpYUePhjBlvNaKclWQ8WInz7x/5Ot0GcYu zv0DrVjMLDJLJJ4xwuxbvgWpR+OlQdrW++aK9etP5xz1zEG4QHg5J58ErIYyyhLY6cc9 Rcuw== X-Received: by 10.236.135.80 with SMTP id t56mr4395462yhi.126.1359645739308; Thu, 31 Jan 2013 07:22:19 -0800 (PST) Received: from ormaajbox (71-220-13-116.mpls.qwest.net. [71.220.13.116]) by mx.google.com with ESMTPS id t2sm4465099anj.3.2013.01.31.07.22.16 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 31 Jan 2013 07:22:17 -0800 (PST) From: Dan Douglas To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] readme.gentoo.eclass: Add a DISABLE_AUTOFORMATTING variable Date: Thu, 31 Jan 2013 09:22:04 -0600 Message-ID: <2397459.bCZm6DZF3s@smorgbox> User-Agent: KMail/4.8.3 (Linux/3.4.6-pf+; KDE/4.8.3; x86_64; ; ) In-Reply-To: <1359295221.2927.24.camel@belkin4> References: <1359295221.2927.24.camel@belkin4> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3324434.nvscHxx18N"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit X-Archives-Salt: bbb3491e-e5d5-4548-9b75-3e3b87a51878 X-Archives-Hash: 1c55952173c05defeae995b6c19a45d7 --nextPart3324434.nvscHxx18N Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" On Sunday, January 27, 2013 03:00:21 PM Pacho Ramos wrote: > Currently, when people uses DOC_CONTENTS variable to place their desired > messages, they are automatically reformatted by "fmt" to get proper > messages (for example, splitting long lines). > > But, in some cases, may be useful to disable this behavior and respect > strictly how DOC_CONTENTS was formatted, for example in that kind of > messages telling people to run a command and, then, requiring a new line > to be used. This can also be useful to append extra information to > DOC_CONTENTS when, for example, additional info is needed when enabling > a USE flag. > Why does this eclass even exist? Everything that it does can be done directly in an ebuild in a couple lines of code, except in a much less ugly manner. It doesn't help to generalize anything. If you want to copy a file and call dodoc then just do it, don't write a pointless wrapper that people then have to go and look up what it does in order to read your ebuilds. The only thing I see that's maybe useful is saving on the logic for checking REPLACING_VERSIONS. You can get rid of all that UUOC / UUOE. The set -f and eshopts stuff is unnecessary. You should localize the variables that can be localized like ELINE. Funnily, looking at the implementation of elog, it appears to already mangle its input by a pass of `echo -e', pointlessly reading lines and joining them back together again repeatedly. This is just horrible! I don't even... -- Dan Douglas --nextPart3324434.nvscHxx18N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEABECAAYFAlEKjCIACgkQMmyDamdg+MwSqgCfe8yXa4+NGNTProQf3PFYKFca LgwAn1AEmFNBoxm/Bkz01TAVDX4UlPof =qaCC -----END PGP SIGNATURE----- --nextPart3324434.nvscHxx18N--