public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org, kde@gentoo.org, base-system@gentoo.org
Subject: [gentoo-dev] [PATCH 5/5] cmake.eclass: Add src_install() check for CMake-4-incompatible modules
Date: Sun, 15 Jun 2025 22:31:48 +0200	[thread overview]
Message-ID: <2321014.iZASKD2KPV@tuxbrain.fritz.box> (raw)
In-Reply-To: <12693580.O9o76ZdvQC@tuxbrain.fritz.box>

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

See examples:
https://bugs.gentoo.org/953075
https://bugs.gentoo.org/957670
https://bugs.gentoo.org/957671
https://bugs.gentoo.org/957803

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
---
 eclass/cmake.eclass | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
index d61992576565..109227edfe02 100644
--- a/eclass/cmake.eclass
+++ b/eclass/cmake.eclass
@@ -807,6 +807,25 @@ cmake_src_install() {
 		einstalldocs
 		popd > /dev/null || die
 	fi
+
+	local file files=()
+	while read -d '' -r file ; do
+		# Detect unsupported minimum CMake versions unless CMAKE_QA_COMPAT_SKIP is set
+		if ! [[ ${CMAKE_QA_COMPAT_SKIP} ]]; then
+			_cmake_minreqver-lt "3.5" "${file}" && files+=( "${file#"${D}"}" )
+		fi
+	done < <(find "${D}" -type f -iname "*.cmake" -print0 || die)
+	if [[ ${#files[*]} -gt 0 ]]; then
+		eqawarn "QA Notice: Package installs CMake module(s) incompatible with CMake 4,"
+		eqawarn "breaking any packages relying on it:"
+		eqawarn
+		for file in "${files[@]}"; do
+			eqawarn "    ${file}"
+		done
+		eqawarn
+		eqawarn "See also tracker bug #951350; check existing bug or file a new one for"
+		eqawarn "this package, and take it upstream."
+	fi
 }
 
 fi
-- 
2.49.0


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 789 bytes --]

  parent reply	other threads:[~2025-06-15 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-15 20:26 [gentoo-dev] [PATCH 1/5] cmake.eclass: Improve _cmake_modify-cmakelists(), consolidate the sed Andreas Sturmlechner
2025-06-15 20:30 ` [gentoo-dev] [PATCH 2/5] cmake.eclass: Introduce _CMAKE_MINREQVER_UNSUPPORTED Andreas Sturmlechner
2025-06-15 20:31 ` [gentoo-dev] [PATCH 3/5] cmake.eclass: mv _CMAKE_MINREQVER_UNSUPPORTED detection to src_prepare Andreas Sturmlechner
2025-06-15 20:31 ` [gentoo-dev] [PATCH 4/5] cmake.eclass: Avoid none-detection by ensuring match starts w/ digit Andreas Sturmlechner
2025-06-15 20:31 ` Andreas Sturmlechner [this message]
2025-06-16  5:19 ` [gentoo-dev] [PATCH 1/5] cmake.eclass: Improve _cmake_modify-cmakelists(), consolidate the sed Ulrich Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2321014.iZASKD2KPV@tuxbrain.fritz.box \
    --to=asturm@gentoo.org \
    --cc=base-system@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=kde@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox