From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 178B8158287 for ; Sat, 17 May 2025 21:31:24 +0000 (UTC) Received: from lists.gentoo.org (bobolink.gentoo.org [140.211.166.189]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 01580343357 for ; Sat, 17 May 2025 21:31:24 +0000 (UTC) Received: from bobolink.gentoo.org (localhost [127.0.0.1]) by bobolink.gentoo.org (Postfix) with ESMTP id 425AC1104A8; Sat, 17 May 2025 21:30:40 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bobolink.gentoo.org (Postfix) with ESMTPS id 8035F1103DD for ; Sat, 17 May 2025 21:30:39 +0000 (UTC) Received: from tuxbrain.fritz.box (unknown [IPv6:2a04:9546:191d:b501:676c:7b0c:c3fa:aa8e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: asturm) by smtp.gentoo.org (Postfix) with ESMTPSA id 85B873432C1; Sat, 17 May 2025 21:30:38 +0000 (UTC) From: Andreas Sturmlechner To: gentoo-dev@lists.gentoo.org, kde@gentoo.org, base-system@gentoo.org Subject: Re: [gentoo-dev] [PATCH] cmake.eclass: Add recursive CMakeLists.txt unsupported version detection Date: Sat, 17 May 2025 23:30:34 +0200 Message-ID: <2319831.iZASKD2KPV@tuxbrain.fritz.box> In-Reply-To: References: <12677532.O9o76ZdvQC@tuxbrain.fritz.box> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2013847.PYKUYFuaPT"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Archives-Salt: 020bf6e5-a972-4ffd-a62d-5227a052371b X-Archives-Hash: d7e5603db8b7abb803cbe2eb87630072 --nextPart2013847.PYKUYFuaPT Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Andreas Sturmlechner Date: Sat, 17 May 2025 23:30:34 +0200 Message-ID: <2319831.iZASKD2KPV@tuxbrain.fritz.box> In-Reply-To: MIME-Version: 1.0 On Samstag, 17. Mai 2025 22:42:30 Mitteleurop=C3=A4ische Sommerzeit Ionen W= olkens=20 wrote: > Just to note, may be rare so guess not a big deal but, while crawling > all sub-directories, it could pickup some extra CMakeLists.txt that are > entirely unused (by us) and don't need attention downstream. On Samstag, 17. Mai 2025 23:03:42 Mitteleurop=C3=A4ische Sommerzeit Ionen W= olkens=20 wrote: > Haven't looked at that closely code-wise though, it'd be nicer to > avoid doing grep twice. Could address both points by limiting the crawling to maxdepth 1 or 2 and=20 always do the regex, without pre-filtering through a first grep, and probab= ly=20 catch most of the brokenness. However, that would have already failed media-libs/opencv-4.10 which in its= =20 most extreme case had too low a minimum version even 6 subdirs deep... otoh= I=20 already know of at least digikam also causing false warnings in its subdirs= -=20 but then these are only one or two upstream build system changes away from= =20 becoming errors. Regards --nextPart2013847.PYKUYFuaPT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEEmaksxp6GvcraXyZQrlkbvHPk3V4FAmgo//pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk5 QTkyQ0M2OUU4NkJEQ0FEQTVGMjY1MEFFNTkxQkJDNzNFNERENUUACgkQrlkbvHPk 3V6wqAwAkiTmywRCVEwBFB8t738uQtzYh5Qf6hFY6hQOxv6dVC6X+2L8h0h2wEsu 0jv2Iek/UgL1mMqGz28JDnMvTILr55TziYBcpmppqRRcm/dmDh4UCs1mo52yDkUW NNxB3oYZY7uf6BeyCQ2xaS2QHL7ciiIJmogvY29rn0Ps0eMRc0vIHLWl1MmvQTKK sUfjN9U1UdmpWvuuhINrQQzSAfNcfb1/vCyf7R4uDUwDeEKrESZ8eK+jSmQQkwla UbSXcDp/ol/w/JTPAAGPa+BzorpjMCcRdGDXTbvVCgh4fHui/P5P0knPUQaGXGtQ zGuN2VVDJ3xouaJdgyouvK5wHLYjCZWYx5MRVp3h5+Rw2cyHCnCp45TuERFgzqj9 JgNlo7+tYDby6A48dGG2q+KyEDXscCNrW2RiRnTUfoNoPuD/g+JXhPOwZDMX5oUx e3vfNO1I00wdVKypNHULACATBsVMzmlPm7MN3tH4FpS5KtApI7TrtyYKjEMVoJ6N +h3hrO1e =itH/ -----END PGP SIGNATURE----- --nextPart2013847.PYKUYFuaPT--