Re: [gentoo-dev] [PATCH] cmake.eclass: Add recursive CMakeLists.txt unsupported version detection

[Andreas Sturmlechner <asturm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]

On Samstag, 17. Mai 2025 22:42:30 Mitteleuropäische Sommerzeit Ionen Wolkens 
wrote:
> Just to note, may be rare so guess not a big deal but, while crawling
> all sub-directories, it could pickup some extra CMakeLists.txt that are
> entirely unused (by us) and don't need attention downstream.

On Samstag, 17. Mai 2025 23:03:42 Mitteleuropäische Sommerzeit Ionen Wolkens 
wrote:
> Haven't looked at that closely code-wise though, it'd be nicer to
> avoid doing grep twice.

Could address both points by limiting the crawling to maxdepth 1 or 2 and 
always do the regex, without pre-filtering through a first grep, and probably 
catch most of the brokenness.

However, that would have already failed media-libs/opencv-4.10 which in its 
most extreme case had too low a minimum version even 6 subdirs deep... otoh I 
already know of at least digikam also causing false warnings in its subdirs - 
but then these are only one or two upstream build system changes away from 
becoming errors.

Regards

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 789 bytes --]