From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 201A1138334 for ; Fri, 20 Sep 2019 20:03:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7F2CEE08C2; Fri, 20 Sep 2019 20:03:24 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 29C10E08AD for ; Fri, 20 Sep 2019 20:03:24 +0000 (UTC) Received: from pomiot (c134-66.icpnet.pl [85.221.134.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 6CB9D34B435; Fri, 20 Sep 2019 20:03:22 +0000 (UTC) Message-ID: <22cf484a144a107088af85164dd1fea6028060a0.camel@gentoo.org> Subject: Re: [gentoo-dev] Underscores in USE flags From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 20 Sep 2019 22:03:18 +0200 In-Reply-To: References: <5fc919ec85751bd88d4bf0775ba1733584f92dc2.camel@gentoo.org> <20e57b194284c4d20e6781573fd0387257aed9f1.camel@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Uo7bWRdbCqhg7WMC4CCp" User-Agent: Evolution 3.32.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 4a5ec4d4-ee1b-4ad4-b2be-8c06fbece5d2 X-Archives-Hash: 5bb1a99738f173e5b5f760dde670eacc --=-Uo7bWRdbCqhg7WMC4CCp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-09-20 at 13:24 -0400, Mike Gilbert wrote: > On Fri, Sep 20, 2019 at 12:55 PM Micha=C5=82 G=C3=B3rny wrote: > > On Fri, 2019-09-20 at 12:41 -0400, Mike Gilbert wrote: > > > On Fri, Sep 20, 2019 at 12:11 PM Micha=C5=82 G=C3=B3rny wrote: > > > > On Fri, 2019-09-20 at 11:46 -0400, Mike Gilbert wrote: > > > > > Recently, a large number of bugs were filed against packages that= have > > > > > USE flag names which contain underscores. Apparently PMS prohibit= s > > > > > this except when the USE flag is part of a USE_EXPAND variable. > > > > >=20 > > > > > https://projects.gentoo.org/pms/7/pms.html#x1-200003.1.4 > > > > >=20 > > > > > I'm not certain when this text was added to PMS, or how many of t= he > > > > > affected USE flags pre-date this policy. > > > > >=20 > > > > > Portage seems to have no issue dealing with underscores, so this > > > > > doesn't seem to be solving any technical problem. > > > > >=20 > > > > > I am pretty sure that renaming a bunch of USE flags will cause so= me > > > > > amount of end-user confusion, for very little benefit. Is enforci= ng > > > > > this part of PMS really worth it? > > > >=20 > > > > And having packages with pretended-USE_EXPAND-that-does-not-work-as= - > > > > USE_EXPAND is less confusing to the users? > > >=20 > > > I doubt users immediately think "USE_EXPAND" when they see an undersc= ore. > > >=20 > > > Portage's seems fairly unambiguous to me. For example: > > >=20 > > > % emerge -pv1O app-misc/foo > > >=20 > > > These are the packages that would be merged, in order: > > >=20 > > > [ebuild N ] app-misc/foo-0::local USE=3D"-modern_kernel" > > > PYTHON_TARGETS=3D"python3_7" VIDEO_CARDS=3D"radeon" 0 KiB > > >=20 > > > Total: 1 package (1 new), Size of downloads: 0 KiB > > >=20 > > > I don't think anyone would mistake "modern_kernel" for a USE_EXPAND > > > value given the above. > > >=20 > >=20 > > Look at the humongous list of flags on dev-libs/aws-sdk-cpp. They all > > start with 'aws_targets' which is a clear attempt to emulate USE_EXPAND= . > > Expect that they won't work as USE_EXPAND, user typing: > >=20 > > AWS_TARGETS=3D"foo bar baz" > >=20 > > will just wildly confused, and in the end this prefixing is just silly > > and causes the flag names to become awfully long. >=20 > Ok, so you chery-picked one particularly horrible example. The Portage > output still puts them in USE=3D"" section, though the user probably > won't see that given the massive USE flag list. >=20 > My point still stands for many of the other packages in the repo that > don't have several dozen flags. >=20 I'm sorry to say but you can't expect automated software to be able to distinguish a 'not horrible' vs 'horrible' use. The test catches both cases. The latter case deserves fixing, the former usually involves 1-2= =20 flag, so there's no harm in changing it. If for no other reason, then to improve consistency in USE flags and save shift key a bit. The hyphen variant is already in the majority in global flags. What's the harm in having local flags match that? --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-Uo7bWRdbCqhg7WMC4CCp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl2FMIZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA4u2wf/fDQborrE1pLsY4CM5jpUJ8kiM/bFDL6Vcy8AcxItGliKYVhstaXA8bb0 sjjIum3aX+Q/dQ1knm3EnHqzk/bLcLvSKzj5eC/TvdApqfU1s4LiqATLtYSnpO1X idJFzKjDRzSBhk1v50QLtM/1i9Fhv5MCklpZ63UxK8HkzKz4kgramIQVnfiKw60H bBLhW9WzvsG7CQOBAmx/Q9wh1Ixr792AkUdB5QwX28Vz286AH5OSGmlf3IXkSu5a eBYy2h6gmkdmTz82/zaKcSgdkXzRKdqfZfOA2AYoG35Ro/NY5GbhaSuXh75I5/Zt uhq/ywYsU2GCF8cP66AN6oOGY2yjDA== =dr0j -----END PGP SIGNATURE----- --=-Uo7bWRdbCqhg7WMC4CCp--