[gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable

[gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable

[Mike Gilbert]

This was only necessary when we ran phases in parallel.
Also, PMS says this variable should not be modified.
---
 eclass/distutils-r1.eclass | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 7965e91..497bed5 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -628,12 +628,6 @@ distutils-r1_run_phase() {
 	# in the sys.path_importer_cache)
 	mkdir -p "${BUILD_DIR}/lib" || die
 
-	# We need separate home for each implementation, for .pydistutils.cfg.
-	if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
-		local -x HOME=${HOME}/${EPYTHON}
-		mkdir -p "${HOME}" || die
-	fi
-
 	# Set up build environment, bug #513664.
 	local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
 	tc-export AR CC CPP CXX
-- 
2.8.2

Re: [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Fri,  6 May 2016 09:25:50 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> This was only necessary when we ran phases in parallel.
> Also, PMS says this variable should not be modified.
> ---
>  eclass/distutils-r1.eclass | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 7965e91..497bed5 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -628,12 +628,6 @@ distutils-r1_run_phase() {
>  	# in the sys.path_importer_cache)
>  	mkdir -p "${BUILD_DIR}/lib" || die
>  
> -	# We need separate home for each implementation, for .pydistutils.cfg.
> -	if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
> -		local -x HOME=${HOME}/${EPYTHON}
> -		mkdir -p "${HOME}" || die
> -	fi
> -
>  	# Set up build environment, bug #513664.
>  	local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
>  	tc-export AR CC CPP CXX

I have merged this one as well to have both distutils-r1 changes
in a single cache regen.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable

[Matthew Thode]

On 05/06/2016 08:25 AM, Mike Gilbert wrote:
> This was only necessary when we ran phases in parallel.
> Also, PMS says this variable should not be modified.
> ---
>  eclass/distutils-r1.eclass | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 7965e91..497bed5 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -628,12 +628,6 @@ distutils-r1_run_phase() {
>  	# in the sys.path_importer_cache)
>  	mkdir -p "${BUILD_DIR}/lib" || die
>  
> -	# We need separate home for each implementation, for .pydistutils.cfg.
> -	if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
> -		local -x HOME=${HOME}/${EPYTHON}
> -		mkdir -p "${HOME}" || die
> -	fi
> -
>  	# Set up build environment, bug #513664.
>  	local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
>  	tc-export AR CC CPP CXX
> 

Thanks for this, think I reported it a while ago, can't find the bug though.

-- 
-- Matthew Thode (prometheanfire)