public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Matthew Thode <prometheanfire@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable
Date: Sat, 21 May 2016 18:22:49 -0500	[thread overview]
Message-ID: <22ce9d07-4905-0227-f0da-2e3ad206d123@gentoo.org> (raw)
In-Reply-To: <1462541150-14440-1-git-send-email-floppym@gentoo.org>

On 05/06/2016 08:25 AM, Mike Gilbert wrote:
> This was only necessary when we ran phases in parallel.
> Also, PMS says this variable should not be modified.
> ---
>  eclass/distutils-r1.eclass | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 7965e91..497bed5 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -628,12 +628,6 @@ distutils-r1_run_phase() {
>  	# in the sys.path_importer_cache)
>  	mkdir -p "${BUILD_DIR}/lib" || die
>  
> -	# We need separate home for each implementation, for .pydistutils.cfg.
> -	if [[ ! ${DISTUTILS_SINGLE_IMPL} ]]; then
> -		local -x HOME=${HOME}/${EPYTHON}
> -		mkdir -p "${HOME}" || die
> -	fi
> -
>  	# Set up build environment, bug #513664.
>  	local -x AR=${AR} CC=${CC} CPP=${CPP} CXX=${CXX}
>  	tc-export AR CC CPP CXX
> 

Thanks for this, think I reported it a while ago, can't find the bug though.

-- 
-- Matthew Thode (prometheanfire)


      parent reply	other threads:[~2016-05-21 23:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 13:25 [gentoo-dev] [PATCH] distutils-r1.eclass: Do not modify the HOME variable Mike Gilbert
2016-05-21 19:40 ` Michał Górny
2016-05-21 23:22 ` Matthew Thode [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22ce9d07-4905-0227-f0da-2e3ad206d123@gentoo.org \
    --to=prometheanfire@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox