From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 612CA139694 for ; Sat, 11 Mar 2017 14:25:38 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B18BFE0CB6; Sat, 11 Mar 2017 14:25:28 +0000 (UTC) Received: from mail.kph.uni-mainz.de (mail.kph.uni-mainz.de [134.93.132.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 441BBE0C4B for ; Sat, 11 Mar 2017 14:25:27 +0000 (UTC) Received: from mailgate-1.kph.uni-mainz.de (mailgate-1.kph.uni-mainz.de [134.93.132.27]) by mail.kph.uni-mainz.de (8.14.5/8.14.5) with ESMTP id v2BEPNYa040314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 11 Mar 2017 15:25:23 +0100 (CET) (envelope-from ulm@kph.uni-mainz.de) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by mailgate-1.kph.uni-mainz.de (8.14.5/8.14.5) with ESMTP id v2BEPM0b076001; Sat, 11 Mar 2017 15:25:22 +0100 (CET) (envelope-from ulm@kph.uni-mainz.de) Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id v2BEPGZR012611; Sat, 11 Mar 2017 15:25:16 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id v2BEPAhs012607; Sat, 11 Mar 2017 15:25:10 +0100 Date: Sat, 11 Mar 2017 15:25:10 +0100 Message-ID: <22724.2245.580774.926925@a1i15.kph.uni-mainz.de> To: gentoo-dev@lists.gentoo.org Cc: =?iso-8859-2?Q?Micha=B3_G=F3rny?= Subject: Re: [gentoo-dev] [PATCH] estack.eclass: Split estack* logic from eutils In-Reply-To: <20170311135058.3223-1-mgorny@gentoo.org> References: <20170311135058.3223-1-mgorny@gentoo.org> X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="pgp+signed+QVv7pge7P18Tru7"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mailgate-1.kph.uni-mainz.de [134.93.132.27]); Sat, 11 Mar 2017 15:25:22 +0100 (CET) X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mailgate-1.kph.uni-mainz.de X-Archives-Salt: bea6f0fc-708a-4893-b0de-54429e242a2f X-Archives-Hash: 671a225a357a6927b8801c3bd1132bb3 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --pgp+signed+QVv7pge7P18Tru7 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable >>>>> On Sat, 11 Mar 2017, Micha=B3 G=F3rny wrote: > Split the estack=5F* and related functions from eutils into a > dedicated estack.eclass. Those functions have significant complexity > and are not used frequently, therefore they benefit from having a > separate file and an explicit dedicated maintainer. This (and the other new eclass as well) might benefit from protection against inheriting it multiple times: if [[ -z ${=5FESTACK=5FECLASS} ]]; then =5FESTACK=5FECLASS=3D1 # main eclass code here fi --pgp+signed+QVv7pge7P18Tru7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCAAGBQJYxAjEAAoJEMMJBoUcYcJzN3oIAL8ost7YN9RK6ngK0knjG8JF AsjBokxM6PRRX7lncCmbQKHFxKffg66nqNbndnGqH1GO/l5Ez63I2dwPTcSpbH1z lS5HP/+PD3wj/V+4EMbX8xhlEV6dKI/odvOt2Ixtquv2O+tjrvihOb8E9M0tJfAw dPGQvZY3zgFRXAjOXdIqQOH2/rcPbpE9e83OU4tnKOVKsmBX+bYOhEQqH3FGQy5+ ixbkT/ckQuQR4X9MrULXrFQfMO5Y6iraJGSdBOhx5ThE1hjebFPFhtkcQXnHw5xp bREeExrOgXwguchg+pj28DcAyhfZ6cDijQtzTfny6h+STxLcx2OTVUUgtVY5oF4= =DcsK -----END PGP SIGNATURE----- --pgp+signed+QVv7pge7P18Tru7--