From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] estack.eclass: Split estack* logic from eutils
Date: Sat, 11 Mar 2017 15:25:10 +0100 [thread overview]
Message-ID: <22724.2245.580774.926925@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20170311135058.3223-1-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
>>>>> On Sat, 11 Mar 2017, Michał Górny wrote:
> Split the estack_* and related functions from eutils into a
> dedicated estack.eclass. Those functions have significant complexity
> and are not used frequently, therefore they benefit from having a
> separate file and an explicit dedicated maintainer.
This (and the other new eclass as well) might benefit from protection
against inheriting it multiple times:
if [[ -z ${_ESTACK_ECLASS} ]]; then
_ESTACK_ECLASS=1
# main eclass code here
fi
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2017-03-11 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 13:50 [gentoo-dev] [PATCH] estack.eclass: Split estack* logic from eutils Michał Górny
2017-03-11 14:25 ` Ulrich Mueller [this message]
2017-03-11 14:59 ` [gentoo-dev] [PATCH v2] " Michał Górny
2017-03-12 10:13 ` [gentoo-dev] [PATCH v3] " Michał Górny
2017-03-18 7:35 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22724.2245.580774.926925@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox