From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org, kde@gentoo.org, base-system@gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2 1/3] cmake.eclass: Add recursive CMakeLists.txt unsupported version detection
Date: Mon, 19 May 2025 20:58:36 +0200 [thread overview]
Message-ID: <22709973.EfDdHjke4D@tuxbrain.fritz.box> (raw)
In-Reply-To: <4c331af88b5ec74a6971fb2942fd7fbcdd5409a2.camel@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 923 bytes --]
On Montag, 19. Mai 2025 20:51:49 Mitteleuropäische Sommerzeit Michał Górny
wrote:
> > --- a/eclass/cmake.eclass
> > +++ b/eclass/cmake.eclass
> > @@ -362,6 +362,18 @@ cmake_src_configure() {
> >
> > # Fix xdg collision with sandbox
> > xdg_environment_reset
> >
> > + local file re="cmake_minimum_required *\( *VERSION( .*\.\.\.|
> > )(([[:digit:]]+)\.([[:digit:]]+))" + local ver cmreq_isold
> > + while read -d '' -r file ; do
> > + [[ $(grep -hi "cmake_minimum_required" "$file") =~ $re ]]
> > + ver="${BASH_REMATCH[2]}"
>
> So... you're using grep to find a line containing
> "cmake_minimum_required", then applying another regexp to that line?
> This really looks like a case for a single sed call.
I'm glad for any suggestions there.
>
> > + echo $file $ver
>
> Is this leftover debug?
Indeed, thanks.
PR is here:
https://github.com/gentoo/kde/pull/1043
Regards
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 789 bytes --]
next prev parent reply other threads:[~2025-05-19 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 20:04 [gentoo-dev] [PATCH] cmake.eclass: Add recursive CMakeLists.txt unsupported version detection Andreas Sturmlechner
2025-05-17 20:42 ` Ionen Wolkens
2025-05-17 21:03 ` Ionen Wolkens
2025-05-17 21:30 ` Andreas Sturmlechner
2025-05-18 2:42 ` Eli Schwartz
2025-05-19 18:44 ` [gentoo-dev] [PATCH v2 1/3] " Andreas Sturmlechner
2025-05-19 18:46 ` [gentoo-dev] [PATCH v2 2/3] cmake.eclass: If CMake 4 is detected, build w/ compat cmake arg Andreas Sturmlechner
2025-05-19 18:47 ` [gentoo-dev] [PATCH v2 3/3] cmake.eclass: Add CMAKE_QA_COMPAT_SKIP flag to skip compat checks Andreas Sturmlechner
2025-05-19 18:51 ` [gentoo-dev] [PATCH v2 1/3] cmake.eclass: Add recursive CMakeLists.txt unsupported version detection Michał Górny
2025-05-19 18:58 ` Andreas Sturmlechner [this message]
2025-06-02 20:44 ` [gentoo-dev] [PATCH v3 " Andreas Sturmlechner
2025-06-02 20:46 ` [gentoo-dev] [PATCH v3 2/3] cmake.eclass: If CMake 4 is detected, build w/ compat cmake arg Andreas Sturmlechner
2025-06-02 20:47 ` [gentoo-dev] [PATCH v3 3/3] cmake.eclass: Add CMAKE_QA_COMPAT_SKIP flag to skip compat checks Andreas Sturmlechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22709973.EfDdHjke4D@tuxbrain.fritz.box \
--to=asturm@gentoo.org \
--cc=base-system@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=kde@gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox