From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9D88213832E for ; Mon, 22 Aug 2016 07:31:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EEA7821C07B; Mon, 22 Aug 2016 07:30:48 +0000 (UTC) Received: from mail.kph.uni-mainz.de (mail.kph.uni-mainz.de [134.93.132.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D3A6B21C039 for ; Mon, 22 Aug 2016 07:30:47 +0000 (UTC) Received: from mailgate-1.kph.uni-mainz.de (mailgate-1.kph.uni-mainz.de [134.93.132.27]) by mail.kph.uni-mainz.de (8.14.5/8.14.5) with ESMTP id u7M7Ue61057914 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Aug 2016 09:30:40 +0200 (CEST) (envelope-from ulm@kph.uni-mainz.de) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by mailgate-1.kph.uni-mainz.de (8.14.5/8.14.5) with ESMTP id u7M7UdHE033145; Mon, 22 Aug 2016 09:30:39 +0200 (CEST) (envelope-from ulm@kph.uni-mainz.de) Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.8/8.14.2) with ESMTP id u7M7Ubdm012776; Mon, 22 Aug 2016 09:30:37 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.8/8.14.8/Submit) id u7M7UbnX012773; Mon, 22 Aug 2016 09:30:37 +0200 Message-ID: <22458.43548.445226.8005@a1i15.kph.uni-mainz.de> Date: Mon, 22 Aug 2016 09:30:36 +0200 To: gentoo-dev@lists.gentoo.org Cc: Thomas Deutschmann Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied In-Reply-To: <20160821221448.61119-1-whissi@gentoo.org> References: <20160821221448.61119-1-whissi@gentoo.org> X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="pgp+signed+GmdlxNUPLrYx33w"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (mailgate-1.kph.uni-mainz.de [134.93.132.27]); Mon, 22 Aug 2016 09:30:39 +0200 (CEST) X-Spam-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mailgate-1.kph.uni-mainz.de X-Archives-Salt: 03d5c251-9284-4655-90b2-e198d5433161 X-Archives-Hash: 502b19fc0a976d098f3be6ccc910ef2c This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --pgp+signed+GmdlxNUPLrYx33w Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit >>>>> On Mon, 22 Aug 2016, Thomas Deutschmann wrote: > [...] > This commit adds a new global variable "EPATCH_N_APPLIED_PATCHES" > which tracks the number of applied user patches. This allows us to > only show the notice when user patches were really applied. I wonder if extending an obsolete feature is worth the effort. In EAPI 6, epatch_user has been replaced by eapply_user. > + : $(( EPATCH_N_APPLIED_PATCHES++ )) Why not simply: (( EPATCH_N_APPLIED_PATCHES++ )) > + if [[ ${old_n_applied_patches} -lt ${EPATCH_N_APPLIED_PATCHES} ]]; then > + has epatch_user_death_notice ${EBUILD_DEATH_HOOKS} || EBUILD_DEATH_HOOKS+=" epatch_user_death_notice" Please keep lines no wider than 80 character positions. Ulrich --pgp+signed+GmdlxNUPLrYx33w Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCAAGBQJXuqoIAAoJEMMJBoUcYcJzp9EH/0p5xlGUqnTfRAG9ghA2TrXw +eMLNbEyb6fC39w1j/da8N6UmaOquQGgl6pEP38NRQowxjLYQZ0W4MtyAFZB4mIg kAZ8ynYZobs9+z2gsokZjRWG3DHWAlGy0cjRzX0RZFv+5DGREB0chONXgycKPUKo fUL7yhfRCnaPNnThLwBBTlO0/Qiz3llz7Pyl5rsb5jx+jP7RpB7Sv0J54QSaOIUe dSOSjjHOa7weBU5Y6V3DIE/4dT5brTErNCGAf5hq2jbutx+Z1vyvxh8CEEdhCDlE oZ0uHQ8DrcnIOOfrQsrVTw2RGCkCGb6AQk/xVGdvvDgJEVWDzNzDgkny0Boa+wk= =XaTw -----END PGP SIGNATURE----- --pgp+signed+GmdlxNUPLrYx33w--