From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Thomas Deutschmann <whissi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied
Date: Mon, 22 Aug 2016 09:30:36 +0200 [thread overview]
Message-ID: <22458.43548.445226.8005@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20160821221448.61119-1-whissi@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
>>>>> On Mon, 22 Aug 2016, Thomas Deutschmann wrote:
> [...]
> This commit adds a new global variable "EPATCH_N_APPLIED_PATCHES"
> which tracks the number of applied user patches. This allows us to
> only show the notice when user patches were really applied.
I wonder if extending an obsolete feature is worth the effort.
In EAPI 6, epatch_user has been replaced by eapply_user.
> + : $(( EPATCH_N_APPLIED_PATCHES++ ))
Why not simply:
(( EPATCH_N_APPLIED_PATCHES++ ))
> + if [[ ${old_n_applied_patches} -lt ${EPATCH_N_APPLIED_PATCHES} ]]; then
> + has epatch_user_death_notice ${EBUILD_DEATH_HOOKS} || EBUILD_DEATH_HOOKS+=" epatch_user_death_notice"
Please keep lines no wider than 80 character positions.
Ulrich
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2016-08-22 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 22:14 [gentoo-dev] [PATCH] eutils.eclass: Show death notice only when user patches were really applied Thomas Deutschmann
2016-08-22 7:30 ` Ulrich Mueller [this message]
2016-08-22 10:11 ` Thomas Deutschmann
2016-08-22 11:16 ` Ulrich Mueller
2016-08-22 11:48 ` Michał Górny
2016-08-22 17:29 ` [gentoo-dev] [PATCH v2] " Thomas Deutschmann
2016-08-23 17:25 ` [gentoo-dev] [PATCH v3] " Thomas Deutschmann
2016-08-23 17:25 ` Thomas Deutschmann
2016-08-31 16:46 ` Thomas Deutschmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22458.43548.445226.8005@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=whissi@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox