From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Michał Górny" <mgorny@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] git-r3.eclass: Support EGIT_SUBMODULES to filter used submodules, #497164
Date: Mon, 23 May 2016 22:54:09 +0200 [thread overview]
Message-ID: <22339.28145.503540.74975@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20160523195419.11522-1-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
>>>>> On Mon, 23 May 2016, Michał Górny wrote:
> +if [[ ${EGIT_SUBMODULES[@]+1} && $(declare -p EGIT_SUBMODULES) != "declare -a"* ]]
> +then
> + die 'EGIT_SUBMODULES must be an array.'
> +fi
Must this test be in global scope?
Ulrich
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2016-05-23 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 19:54 [gentoo-dev] [PATCH] git-r3.eclass: Support EGIT_SUBMODULES to filter used submodules, #497164 Michał Górny
2016-05-23 20:06 ` Patrice Clement
2016-05-23 20:14 ` Michał Górny
2016-05-23 20:57 ` Ulrich Mueller
2016-05-23 20:54 ` Ulrich Mueller [this message]
2016-05-26 8:12 ` Michał Górny
2016-05-26 9:00 ` Michał Górny
2016-05-27 19:16 ` Daniel Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22339.28145.503540.74975@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=mgorny@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox