[gentoo-dev] [PATCH] readme.gentoo.eclass EAPI 6 support

[gentoo-dev] [PATCH] readme.gentoo.eclass EAPI 6 support

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

AFAICS there are no particular EAPI 6 features this eclass could make
use of, so we can simply add 6 to the case pattern.

Ulrich


--- a/eclass/readme.gentoo.eclass
+++ b/eclass/readme.gentoo.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2014 Gentoo Foundation
+# Copyright 1999-2015 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 # $Id$
 
@@ -24,7 +24,7 @@ case "${EAPI:-0}" in
 	0|1|2|3)
 		die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
 		;;
-	4|5)
+	4|5|6)
 		# EAPI>=4 is required for REPLACING_VERSIONS preventing us
 		# from needing to export another pkg_preinst phase to save has_version
 		# result. Also relies on EAPI >=4 default src_install phase.

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: [gentoo-dev] [PATCH] readme.gentoo.eclass EAPI 6 support

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

On Tue, 8 Dec 2015 23:53:26 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:

> AFAICS there are no particular EAPI 6 features this eclass could make
> use of, so we can simply add 6 to the case pattern.

We could use EAPI 6 as an opportunity to fix the API and stop overriding
src_install() randomly.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 949 bytes --]

Re: [gentoo-dev] [PATCH] readme.gentoo.eclass EAPI 6 support

[Ulrich Mueller]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

>>>>> On Wed, 9 Dec 2015, Michał Górny wrote:

>> AFAICS there are no particular EAPI 6 features this eclass could
>> make use of, so we can simply add 6 to the case pattern.

> We could use EAPI 6 as an opportunity to fix the API and stop
> overriding src_install() randomly.

I'm not fond of cluttering the eclass with so-called EAPI conditionals
that have nothing to do with the EAPI in question. If the eclass's API
is changed, making a new revision of the eclass is much cleaner.

Ulrich

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]