From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 7/9] multilib-build.eclass: Enable EAPI 6
Date: Sun, 6 Dec 2015 22:48:03 +0100 [thread overview]
Message-ID: <22116.44307.311862.972221@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <20151206214309.3126971e@symphony.aura-online.co.uk>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
>>>>> On Sun, 6 Dec 2015, James Le Cuirot wrote:
>> > # EAPI=4 is required for meaningful MULTILIB_USEDEP.
>> > case ${EAPI:-0} in
>> > - 4|5) ;;
>> > + [456]) ;;
>> > *) die "EAPI=${EAPI} is not supported" ;;
>> > esac
>>
>> Why not write this as 4|5|6) for better readability? It's not even
>> shorter with the brackets.
> Or [4-6]) perhaps? It would not get any longer for later versions. ;)
I'd rather avoid any syntax that suggests that EAPI names are single
characters.
Ulrich
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2015-12-06 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 18:57 [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 1/9] multilib-build.eclass: Mark eclass-generated variables read-only Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 2/9] multilib-build.eclass: Add missing error checks Michał Górny
2015-12-06 20:23 ` James Le Cuirot
2015-12-06 20:28 ` James Le Cuirot
2015-12-06 18:57 ` [gentoo-dev] [PATCH 3/9] multilib-build.eclass: Unset local functions after use Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 4/9] multilib-build.eclass: Unset global-setting function " Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 5/9] multilib-build.eclass: Ban deprecated functions in EAPI 6 Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 6/9] multilib-build.eclass: Add missing eutils inherit for eqawarn Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 7/9] multilib-build.eclass: Enable EAPI 6 Michał Górny
2015-12-06 21:32 ` Ulrich Mueller
2015-12-06 21:43 ` James Le Cuirot
2015-12-06 21:48 ` Ulrich Mueller [this message]
2015-12-06 18:57 ` [gentoo-dev] [PATCH 8/9] multilib-minimal.eclass: Remove eutils in EAPI 6 (einstalldocs built-in) Michał Górny
2015-12-06 18:57 ` [gentoo-dev] [PATCH 9/9] multilib-minimal.eclass: Enable EAPI 6 Michał Górny
2015-12-09 20:45 ` [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset Michał Górny
2015-12-11 5:57 ` Doug Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22116.44307.311862.972221@a1i15.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox