From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 59DDE1581FB for ; Sun, 25 Aug 2024 15:38:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3F29CE2A5F; Sun, 25 Aug 2024 15:38:48 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 01DAEE2A54 for ; Sun, 25 Aug 2024 15:38:48 +0000 (UTC) Message-ID: <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org> Date: Sun, 25 Aug 2024 11:36:30 -0400 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir To: gentoo-dev@lists.gentoo.org References: <20240825153341.21121-1-mgorny@gentoo.org> Content-Language: en-US From: Eli Schwartz Autocrypt: addr=eschwartz@gentoo.org; keydata= xjMEZmeRNBYJKwYBBAHaRw8BAQdAYNZ7pUDWhx1i2f3p6L2ZLu4FcY18UoeGC04Gq/khqwfN I0VsaSBTY2h3YXJ0eiA8ZXNjaHdhcnR6QGdlbnRvby5vcmc+wpYEExYKAD4WIQTvUdMIsc4j CIi+DYTqQj6ToWND8QUCZoRL+gIbAwUJBKKGAAULCQgHAwUVCgkICwUWAgMBAAIeBQIXgAAK CRDqQj6ToWND8aB5AP9r4kB691nNtNwKkdRiOdl7/k6WYzokvHvDamXxRJ0I+gEAjZqR5V8y mfR3fy2Z+r2Joeqdt3CIv5IwPs64spBvigLOOARmZ5E0EgorBgEEAZdVAQUBAQdATT46Z06b 1X9xjXFCYFxmq/Tj3tSEKZInDWTpoHQp4l8DAQgHwn4EGBYKACYWIQTvUdMIsc4jCIi+DYTq Qj6ToWND8QUCZmeRNAIbDAUJBKKGAAAKCRDqQj6ToWND8a2RAP40KPfbfoiZAJW5boFmFJ3G TUBDJRh9CWHyaPqq2PN+0wD/R07oLzfnJUN209mzi9TuTuHjeZybysyqXSw4MAxkMAY= In-Reply-To: <20240825153341.21121-1-mgorny@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------4nf09WMqE2j0wgCYJRJEMNdh" X-Archives-Salt: f685f029-7de3-4178-a7f0-b50f95fd810b X-Archives-Hash: 8836fa3324c04c54fe7ac9a7abf388c2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------4nf09WMqE2j0wgCYJRJEMNdh Content-Type: multipart/mixed; boundary="------------vW737YtibSIyF5Xy09f22sK6"; protected-headers="v1" From: Eli Schwartz To: gentoo-dev@lists.gentoo.org Message-ID: <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir References: <20240825153341.21121-1-mgorny@gentoo.org> In-Reply-To: <20240825153341.21121-1-mgorny@gentoo.org> --------------vW737YtibSIyF5Xy09f22sK6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 8/25/24 11:33 AM, Micha=C5=82 G=C3=B3rny wrote: > Closes: https://bugs.gentoo.org/937642 > Signed-off-by: Micha=C5=82 G=C3=B3rny > --- > eclass/distutils-r1.eclass | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > index 0f9dc8d14d5e..39705c5c3c84 100644 > --- a/eclass/distutils-r1.eclass > +++ b/eclass/distutils-r1.eclass > @@ -2109,8 +2109,10 @@ _distutils-r1_post_python_install() { > local strays=3D() > local p > mapfile -d $'\0' -t strays < <( > + # jar for jpype, https://bugs.gentoo.org/937642 > find "${sitedir}" -maxdepth 1 -type f '!' '(' \ > -name '*.egg-info' -o \ > + -name '*.jar' -o \ > -name '*.pth' -o \ > -name '*.py' -o \ > -name '*.pyi' -o \ Copying my comment from the bug report: I don't think it makes sense to add a special exception for jar files. If we think that packages may be legitimately storing *data* files at the top level, we should either relax the check in general, or allow adding a suppression variable for packages to suppress this check. --=20 Eli Schwartz --------------vW737YtibSIyF5Xy09f22sK6-- --------------4nf09WMqE2j0wgCYJRJEMNdh Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTnFNnmK0TPZHnXm3qEp9ErcA0vVwUCZstPfgUDAAAAAAAKCRCEp9ErcA0vV0tr AP99wblCgTS/eIPI/NWsPz21T1FXjfenYZzjDEUaiF7y2wEA2gXixfZDCuu7/GC3QCPOv5YrqCpV 2nf5/sizWHzSJQo= =881X -----END PGP SIGNATURE----- --------------4nf09WMqE2j0wgCYJRJEMNdh--