From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DB02A138334 for ; Fri, 20 Sep 2019 16:55:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0D3BCE08CD; Fri, 20 Sep 2019 16:55:45 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B8C0AE085D for ; Fri, 20 Sep 2019 16:55:44 +0000 (UTC) Received: from pomiot (c134-66.icpnet.pl [85.221.134.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 2041034B406; Fri, 20 Sep 2019 16:55:42 +0000 (UTC) Message-ID: <20e57b194284c4d20e6781573fd0387257aed9f1.camel@gentoo.org> Subject: Re: [gentoo-dev] Underscores in USE flags From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 20 Sep 2019 18:55:38 +0200 In-Reply-To: References: <5fc919ec85751bd88d4bf0775ba1733584f92dc2.camel@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-y13WXBxPvDiImdfG1Qx9" User-Agent: Evolution 3.32.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: d23103c9-57f7-4a84-befe-062823b56d2e X-Archives-Hash: 4a8c9e6b0ff27885a8d37735a5fbf623 --=-y13WXBxPvDiImdfG1Qx9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2019-09-20 at 12:41 -0400, Mike Gilbert wrote: > On Fri, Sep 20, 2019 at 12:11 PM Micha=C5=82 G=C3=B3rny wrote: > > On Fri, 2019-09-20 at 11:46 -0400, Mike Gilbert wrote: > > > Recently, a large number of bugs were filed against packages that hav= e > > > USE flag names which contain underscores. Apparently PMS prohibits > > > this except when the USE flag is part of a USE_EXPAND variable. > > >=20 > > > https://projects.gentoo.org/pms/7/pms.html#x1-200003.1.4 > > >=20 > > > I'm not certain when this text was added to PMS, or how many of the > > > affected USE flags pre-date this policy. > > >=20 > > > Portage seems to have no issue dealing with underscores, so this > > > doesn't seem to be solving any technical problem. > > >=20 > > > I am pretty sure that renaming a bunch of USE flags will cause some > > > amount of end-user confusion, for very little benefit. Is enforcing > > > this part of PMS really worth it? > >=20 > > And having packages with pretended-USE_EXPAND-that-does-not-work-as- > > USE_EXPAND is less confusing to the users? >=20 > I doubt users immediately think "USE_EXPAND" when they see an underscore. >=20 > Portage's seems fairly unambiguous to me. For example: >=20 > % emerge -pv1O app-misc/foo >=20 > These are the packages that would be merged, in order: >=20 > [ebuild N ] app-misc/foo-0::local USE=3D"-modern_kernel" > PYTHON_TARGETS=3D"python3_7" VIDEO_CARDS=3D"radeon" 0 KiB >=20 > Total: 1 package (1 new), Size of downloads: 0 KiB >=20 > I don't think anyone would mistake "modern_kernel" for a USE_EXPAND > value given the above. >=20 Look at the humongous list of flags on dev-libs/aws-sdk-cpp. They all start with 'aws_targets' which is a clear attempt to emulate USE_EXPAND. Expect that they won't work as USE_EXPAND, user typing: AWS_TARGETS=3D"foo bar baz" will just wildly confused, and in the end this prefixing is just silly and causes the flag names to become awfully long. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-y13WXBxPvDiImdfG1Qx9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl2FBItfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA49UwgArf05Xeqp4l4Bn9yRFFimJzALWGbIXh7Nw/mf9aAUcTaUZNQLwjLGtmLh K+LOpq5Rewkn8i+GzDadk8b7LpgQb0aq8hsu3ih1/SADELCoWuKwG9L7kNYFR/QW vHo1romwgBo//HVOaQ5d5rhj3GSimQpbOtzGROkuGldmjdvqNJ0oitYE1h/r3IN0 Hh+fi050rIFKd/DMI/L5JY6aja/GzQQAgdB2DWJpSnHjtalsnFnJZ4vywJv58fzL IhkVOkHMCMN0QiN6TGD3x7IYSbDJlrQrkcQQVnfxgnMw39NzlkEZfywEIsbvH03F xF9VMBFWQeu3D0R0oqvd2eeQOal/FA== =8wuO -----END PGP SIGNATURE----- --=-y13WXBxPvDiImdfG1Qx9--