From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-59258-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id B7D8B138010
	for <garchives@archives.gentoo.org>; Sun, 24 Mar 2013 13:41:24 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 4636EE081F;
	Sun, 24 Mar 2013 13:41:05 +0000 (UTC)
Received: from a1www.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 3D77AE081B
	for <gentoo-dev@lists.gentoo.org>; Sun, 24 Mar 2013 13:41:03 +0000 (UTC)
Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92])
	by a1www.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id r2ODewop007643;
	Sun, 24 Mar 2013 14:40:58 +0100
Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1])
	by a1i15.kph.uni-mainz.de (8.14.6/8.14.2) with ESMTP id r2ODewe0006374;
	Sun, 24 Mar 2013 14:40:58 +0100
Received: (from ulm@localhost)
	by a1i15.kph.uni-mainz.de (8.14.6/8.14.6/Submit) id r2ODew3C006370;
	Sun, 24 Mar 2013 14:40:58 +0100
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: 8bit
Message-ID: <20815.618.456234.421581@a1i15.kph.uni-mainz.de>
Date: Sun, 24 Mar 2013 14:40:58 +0100
To: =?iso-8859-2?Q?Micha=B3_G=F3rny?= <mgorny@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] Introduce multibuild_merge_root() to
 merge interim installs.
In-Reply-To: <20130324110931.3ef46f45@pomiocik.lan>
References: <20130323172532.1b1100e2@pomiocik.lan>
	<1364055998-23674-1-git-send-email-mgorny@gentoo.org>
	<20813.57273.945749.854552@a1i15.kph.uni-mainz.de>
	<20130323182858.1846ba8d@pomiocik.lan>
	<20814.44957.706923.881677@a1i15.kph.uni-mainz.de>
	<20130324110931.3ef46f45@pomiocik.lan>
X-Mailer: VM 8.2.0b under 24.3.1 (x86_64-pc-linux-gnu)
From: Ulrich Mueller <ulm@gentoo.org>
X-Archives-Salt: 622dd830-6ffd-4a2b-bef0-6be5750f19c1
X-Archives-Hash: 2e477680a2864094431bd4584896b332

>>>>> On Sun, 24 Mar 2013, Michał Górny wrote:

>> >> > +multibuild_merge_root() {
>> >> > + [...]
>> >> > +	if type -P lockf &>/dev/null; then
>> >> > +		# On BSD, we have 'lockf' wrapper.
>> >> > +		tar -C "${src}" -f - -c . \
>> >> > +			| lockf "${lockfile}" tar -x -f - -C "${dest}"
>> >> > +	else
>> >> > + [...]
>> >> > +		cp -a -l -n "${src}"/. "${dest}"/

>> Maybe explicitly testing for USERLAND would be less fragile? Or use
>> tar everywhere?

> I prefer something that can boom into face and let us know that it
> is broken rather than silent, poor catch-all.

How about adding a couple of "assert" and "die" to tar and cp then?

Ulrich