* [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed
@ 2017-09-03 15:56 Chris Mayo
2017-09-03 21:22 ` Michael Orlitzky
2017-09-30 8:52 ` Patrice Clement
0 siblings, 2 replies; 5+ messages in thread
From: Chris Mayo @ 2017-09-03 15:56 UTC (permalink / raw
To: gentoo-dev
---
Please consider this clarification of optfeature.
Chris
eclass/eutils.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index fe4339f6b89..f35fa5980d7 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -827,8 +827,8 @@ use_if_iuse() {
# @FUNCTION: optfeature
# @USAGE: <short description> <package atom to match> [other atoms]
# @DESCRIPTION:
-# Print out a message suggesting an optional package (or packages) which
-# provide the described functionality
+# Print out a message suggesting an optional package (or packages)
+# not currently installed which provides the described functionality.
#
# The following snippet would suggest app-misc/foo for optional foo support,
# app-misc/bar or app-misc/baz[bar] for optional bar support
--
2.13.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed
2017-09-03 15:56 [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed Chris Mayo
@ 2017-09-03 21:22 ` Michael Orlitzky
2017-09-06 18:39 ` Chris Mayo
2017-09-30 8:52 ` Patrice Clement
1 sibling, 1 reply; 5+ messages in thread
From: Michael Orlitzky @ 2017-09-03 21:22 UTC (permalink / raw
To: gentoo-dev
On 09/03/2017 11:56 AM, Chris Mayo wrote:
> #
> # The following snippet would suggest app-misc/foo for optional foo support,
> # app-misc/bar or app-misc/baz[bar] for optional bar support
>
Would the @EXAMPLE tag[0] make sense here?
[0] https://devmanual.gentoo.org/eclass-writing/index.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed
2017-09-03 21:22 ` Michael Orlitzky
@ 2017-09-06 18:39 ` Chris Mayo
2017-09-06 19:54 ` Michael Orlitzky
0 siblings, 1 reply; 5+ messages in thread
From: Chris Mayo @ 2017-09-06 18:39 UTC (permalink / raw
To: gentoo-dev
On 03/09/17 22:22, Michael Orlitzky wrote:
> On 09/03/2017 11:56 AM, Chris Mayo wrote:
>> #
>> # The following snippet would suggest app-misc/foo for optional foo support,
>> # app-misc/bar or app-misc/baz[bar] for optional bar support
>>
>
> Would the @EXAMPLE tag[0] make sense here?
>
>
> [0] https://devmanual.gentoo.org/eclass-writing/index.html
>
I believe @EXAMPLE is only for the first documentation block introducing the eclass.
At least where it is used for functions the text doesn't show up in the man page.
e.g. prefix.eclass hprefixify() and prefixify_ro()
https://devmanual.gentoo.org/eclass-reference/prefix.eclass/index.html
https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/prefix.eclass?id=61b861acd7b49083dab687e133f30f3331cb7480
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed
2017-09-06 18:39 ` Chris Mayo
@ 2017-09-06 19:54 ` Michael Orlitzky
0 siblings, 0 replies; 5+ messages in thread
From: Michael Orlitzky @ 2017-09-06 19:54 UTC (permalink / raw
To: gentoo-dev
On 09/06/2017 02:39 PM, Chris Mayo wrote:
>
> I believe @EXAMPLE is only for the first documentation block introducing the eclass.
>
> At least where it is used for functions the text doesn't show up in the man page.
> e.g. prefix.eclass hprefixify() and prefixify_ro()
>
Looks like you're right, sorry for the noise.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed
2017-09-03 15:56 [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed Chris Mayo
2017-09-03 21:22 ` Michael Orlitzky
@ 2017-09-30 8:52 ` Patrice Clement
1 sibling, 0 replies; 5+ messages in thread
From: Patrice Clement @ 2017-09-30 8:52 UTC (permalink / raw
To: gentoo-dev
Hi Chris
Sunday 03 Sep 2017 16:56:08, Chris Mayo wrote :
> ---
> Please consider this clarification of optfeature.
>
> Chris
>
> eclass/eutils.eclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
> index fe4339f6b89..f35fa5980d7 100644
> --- a/eclass/eutils.eclass
> +++ b/eclass/eutils.eclass
> @@ -827,8 +827,8 @@ use_if_iuse() {
> # @FUNCTION: optfeature
> # @USAGE: <short description> <package atom to match> [other atoms]
> # @DESCRIPTION:
> -# Print out a message suggesting an optional package (or packages) which
> -# provide the described functionality
> +# Print out a message suggesting an optional package (or packages)
> +# not currently installed which provides the described functionality.
> #
> # The following snippet would suggest app-misc/foo for optional foo support,
> # app-misc/bar or app-misc/baz[bar] for optional bar support
> --
> 2.13.5
>
>
We (Michal Gorny and I) have reviewed your patch and merged it.
Thanks!
--
Patrice Clement
Gentoo Linux developer
http://www.gentoo.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-30 8:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-03 15:56 [gentoo-dev] [PATCH] eutils.eclass: Document optfeature suggests packages not installed Chris Mayo
2017-09-03 21:22 ` Michael Orlitzky
2017-09-06 18:39 ` Chris Mayo
2017-09-06 19:54 ` Michael Orlitzky
2017-09-30 8:52 ` Patrice Clement
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox