From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E0C37138262 for ; Tue, 17 May 2016 23:19:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 31F051427E; Tue, 17 May 2016 23:19:46 +0000 (UTC) Received: from mail-lf0-f67.google.com (mail-lf0-f67.google.com [209.85.215.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0193914275 for ; Tue, 17 May 2016 23:19:44 +0000 (UTC) Received: by mail-lf0-f67.google.com with SMTP id y84so2148732lfc.3 for ; Tue, 17 May 2016 16:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:in-reply-to:references :mime-version; bh=5k9LOGL0i0fgPRSO8MP8Gqbv0128Iykuu3BT63EVqiE=; b=KbSy3LpBjqVbtee2gIsBBWQS0CZGJ+sB4IUHVe0RjUURnpqa8uFTZiAVbjjt+6UEXX XGphaUQBSP5Lz8ZcpddHEsoU51uneN4bDJvBv67mALunzAAA4RhoWrccqVo7RKtSJog7 BixfJP1VvCabAlsHcZVtYkR3G5N/OSM7R29s85PaLiXQXpMWKl8d/Ot19m8ECbi60C+m grlFCCLaXHEyxEB3RVV3wIXSYPEpTaAqHksJDOIOJo3WNwzqaVVUDeX59v6kV3CJK+72 N08bKsBCFfV7sZFXmLGtAshExdwq7AgEFQmE9xvnK5LG3GeWgIepr9DScgpjo59QIOXQ Bg0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :in-reply-to:references:mime-version; bh=5k9LOGL0i0fgPRSO8MP8Gqbv0128Iykuu3BT63EVqiE=; b=WIBGaWknsPrTbr+eX6ptDu0HERdUhRGqVH7DrozOex7hJZuYtC4swzpzbX+5/920I3 SRwoeevC5EhtSz7+EypF65OZ+v65JZzz+ztYv+anp0mp9QL4Gid2koj5kFIrf0Jf1XC+ pymsTGEUT1bJyl2hDl6ib4If/jvBON47xBmwBcVuXGI/menxICIYrWg5XhQKrKgYfQaM sBkBb95YUwye+q5tdKb8RMORS0AgHGARXKeew78ITtRnCxxwg5yElka8T9/KOgPRKN2h RmLKjQxpNs+sqzQccSOBmluP7N21wcIAGmxj0Ef0q+PergzWs9dgnjl9AQNRjgf0gn9s dJNA== X-Gm-Message-State: AOPr4FXr1y487cH7OmH/CXzyo65dQYmhO0QZYCPL8k0dBMknvQ18gryUme1uqJg1v4/FbA== X-Received: by 10.25.22.19 with SMTP id m19mr1516998lfi.118.1463527183500; Tue, 17 May 2016 16:19:43 -0700 (PDT) Received: from liwardyna.localnet (90-156-71-188.internetia.net.pl. [90.156.71.188]) by smtp.gmail.com with ESMTPSA id n8sm886848lbc.17.2016.05.17.16.19.42 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 May 2016 16:19:42 -0700 (PDT) From: Maciej Mrozowski To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [RFC] Enable CMAKE_WARN_UNUSED_CLI by default in cmake-utils for EAPI>=6 Date: Wed, 18 May 2016 01:19:37 +0200 Message-ID: <2069714.hcXsUUITgk@liwardyna> User-Agent: KMail/4.14.10 (Linux/4.4.6-gentoo; KDE/4.14.19; x86_64; ; ) In-Reply-To: <104448202.uyfy7RImdz@liwardyna> References: <2425813.40BMEBc0ED@liwardyna> <104448202.uyfy7RImdz@liwardyna> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2250707.tTUDEvY3gj"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Archives-Salt: f675bc4d-d77a-4728-8644-cf50f31d892a X-Archives-Hash: 735ea9bd4fc1744087588b92336a6ad1 --nextPart2250707.tTUDEvY3gj Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Monday 02 of May 2016 18:13:38 you wrote: > On Monday 02 of May 2016 18:06:44 you wrote: > > Unfortunately there is common misconception, also among developers,= that > > it's sufficient to simply replace "${cmake-utils_use_with foo)" wit= h > > "-DWITH_foo=3DON" etc. >=20 > Obvious errata, should be: > Unfortunately there is common misconception, also among developers, t= hat > it's sufficient to simply replace "${cmake-utils_use_with foo)" with = "- > DWITH_foo=3D$(usex foo)" etc. And commited: diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass index ebcb631..427c13f 100644 =2D-- a/eclass/cmake-utils.eclass +++ b/eclass/cmake-utils.eclass @@ -87,7 +87,6 @@ _CMAKE_UTILS_ECLASS=3D1 # Warn about variables that are declared on the command line # but not used. Might give false-positives. # "no" to disable (default) or anything else to enable. =2D: ${CMAKE_WARN_UNUSED_CLI:=3Dno} =20 # @ECLASS-VARIABLE: PREFIX # @DESCRIPTION: @@ -113,7 +112,8 @@ _CMAKE_UTILS_ECLASS=3D1 # Should be set by user in a per-package basis in /etc/portage/package= .env. =20 case ${EAPI} in =2D 2|3|4|5|6) : ;; + 2|3|4|5) : ${CMAKE_WARN_UNUSED_CLI:=3Dno} ;; + 6) : ${CMAKE_WARN_UNUSED_CLI:=3Dyes} ;; *) die "EAPI=3D${EAPI:-0} is not supported" ;; esac regards MM --nextPart2250707.tTUDEvY3gj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlc7pwkACgkQFuHa/bHpVds15gCgjzhGo5+e2/2Z0MMf2SyDAoGH j60AoKmjbyAedSTxT/B1iYHg0QTFGcWG =uLtH -----END PGP SIGNATURE----- --nextPart2250707.tTUDEvY3gj--