From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 64EAC138010 for ; Fri, 14 Sep 2012 15:52:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7A6DE21C00A; Fri, 14 Sep 2012 15:52:35 +0000 (UTC) Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by pigeon.gentoo.org (Postfix) with ESMTP id F3DF521C02B for ; Fri, 14 Sep 2012 15:51:21 +0000 (UTC) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id q8EFpKxO005696 for ; Fri, 14 Sep 2012 17:51:20 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.5/8.14.2) with ESMTP id q8EFpKhZ008326; Fri, 14 Sep 2012 17:51:20 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.5/8.14.5/Submit) id q8EFpKMS008324; Fri, 14 Sep 2012 17:51:20 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20563.21111.934894.461651@a1i15.kph.uni-mainz.de> Date: Fri, 14 Sep 2012 17:51:19 +0200 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] bzr.eclass changes, please review In-Reply-To: <50532DE2.1060908@gentoo.org> References: <20562.62029.425431.864386@a1i15.kph.uni-mainz.de> <50532DE2.1060908@gentoo.org> X-Mailer: VM 8.2.0b under 23.4.2 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-Archives-Salt: 091fc3b1-10d3-412e-a82d-fd832987ddb3 X-Archives-Hash: 632fad145ac3d774499e09e3a15b8be6 >>>>> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote: >> addwrite / > Am I reading this wrong, or is "addwrite /" being more than just a > little lazy? I know this isn't part of your change set but it has > always bothered me that it needs to unlocking writing on the whole > filesystem to save something in distdir. EBZR_STORE_DIR may be redefined, so you cannot be sure that it's below DISTDIR. Also, it's not known how many of its path components already exist. I'm not sure if it would be worth the effort to compute a more accurate argument for addwrite. (Almost all live eclasses do that "addwrite /", by the way.) >> mkdir -p "${EBZR_STORE_DIR}" \ >> || die "${EBZR}: can't mkdir ${EBZR_STORE_DIR}" Ulrich