public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] bzr.eclass changes, please review
Date: Fri, 14 Sep 2012 17:51:19 +0200	[thread overview]
Message-ID: <20563.21111.934894.461651@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <50532DE2.1060908@gentoo.org>

>>>>> On Fri, 14 Sep 2012, Rick "Zero Chaos" Farina wrote:

>>  		addwrite /
> Am I reading this wrong, or is "addwrite /" being more than just a
> little lazy?  I know this isn't part of your change set but it has
> always bothered me that it needs to unlocking writing on the whole
> filesystem to save something in distdir.

EBZR_STORE_DIR may be redefined, so you cannot be sure that it's below
DISTDIR. Also, it's not known how many of its path components already
exist. I'm not sure if it would be worth the effort to compute a more
accurate argument for addwrite. (Almost all live eclasses do that
"addwrite /", by the way.)

>>  		mkdir -p "${EBZR_STORE_DIR}" \
>>  			|| die "${EBZR}: can't mkdir ${EBZR_STORE_DIR}"

Ulrich


  reply	other threads:[~2012-09-14 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  9:01 [gentoo-dev] bzr.eclass changes, please review Ulrich Mueller
2012-09-14 13:15 ` Rick "Zero_Chaos" Farina
2012-09-14 15:51   ` Ulrich Mueller [this message]
2012-09-14 16:12     ` Rick "Zero_Chaos" Farina
2012-09-14 22:26       ` Mike Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20563.21111.934894.461651@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox