public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Don't require assignment of empty variables in ebuilds?
Date: Wed, 25 Jul 2012 18:38:05 +0200	[thread overview]
Message-ID: <20496.8429.216032.904090@a1i15.kph.uni-mainz.de> (raw)
In-Reply-To: <201207251200.39910.vapier@gentoo.org>

>>>>> On Wed, 25 Jul 2012, Mike Frysinger wrote:

>> Our current policy [1] requires that ebuilds must assign the seven
>> variables DESCRIPTION, HOMEPAGE, SRC_URI, LICENSE, SLOT, KEYWORDS,
>> and IUSE, even if their value is empty.
>> 
>> Could we drop this requirement? Repoman already enforces that
>> DESCRIPTION, HOMEPAGE, LICENSE, SLOT, and KEYWORDS are non-empty
>> (with some exceptions for virtuals). I don't see why we need to
>> distinguish the "empty value" and "not assigned" cases.

> i think we should clarify and say that when an eclass provides
> these, the ebuild need not. completely missing DESCRIPTION/HOMEPAGE
> should be a warning (and maybe KEYWORDS), and LICENSE should be an
> error. there are plenty of examples of SRC_URI not being set and
> that's fine (live ebuilds, ebuilds that only install out of
> $FILESDIR, virtuals, etc...).

I think we have to distinguish between PMS and tree policy here.
The package manager should be able to handle any empty or missing
variables (except for DESCRIPTION and SLOT). Otherwise we'd have to
complicate the spec with additional case distinctions, e.g. for
virtuals.

On the other hand, tree policy (as enforced by repoman) wouldn't
really change. In the cases you've mentioned above, it already
displays errors or warnings. Repoman also doesn't distinguish between
empty and unset variables. The single exception to this is IUSE, which
is required to be present in an ebuild even if it's empty. Maybe we
should drop this requirement, too.

Ulrich


  reply	other threads:[~2012-07-25 16:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-18 17:53 [gentoo-dev] Don't require assignment of empty variables in ebuilds? Ulrich Mueller
2012-07-18 18:02 ` Robin H. Johnson
2012-07-18 18:11   ` Davide Pesavento
2012-07-25 16:00 ` Mike Frysinger
2012-07-25 16:38   ` Ulrich Mueller [this message]
2012-07-25 16:56     ` Pacho Ramos
2012-07-25 17:05       ` Rick "Zero_Chaos" Farina
2012-07-25 18:15     ` Michał Górny
2012-07-25 18:32     ` Mike Frysinger
2012-08-09  2:04     ` Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20496.8429.216032.904090@a1i15.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox