[gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Michał Górny]

USE=magic is currently used consistently by 12 packages:

app-arch/engrampa[magic] Enable filetype auto-detection via
  sys-apps/file
app-editors/nano[magic] Add magic file support (sys-apps/file) to
  automatically detect appropriate syntax highlighting
app-misc/vifm[magic] Use libmagic to determine mimetypes
app-misc/worker[magic] Add magic file support from sys-apps/file to
  automatically detect file types
app-text/zathura[magic] Use libmagic to determine mimetypes
media-gfx/qiv[magic] Use libmagic to determine mimetypes
media-libs/libextractor[magic] Enable magic support using sys-apps/file
media-sound/moc[magic] Use libmagic to determine mimetypes
net-misc/gerbera[magic] Use libmagic to determine file types
net-p2p/mldonkey[magic] enable use of libmagic
sci-geosciences/viking[magic] Use libmagic to determine mimetypes
www-servers/pshs[magic] Enable automatic detection of Content-Type using
  libmagic (sys-apps/file)

Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
 profiles/use.desc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/profiles/use.desc b/profiles/use.desc
index 13baef969315..09940dd81822 100644
--- a/profiles/use.desc
+++ b/profiles/use.desc
@@ -181,6 +181,7 @@ lzma - Support for LZMA (de)compression algorithm
 lzo - Enable support for lzo compression
 m17n-lib - Enable m17n-lib support
 mad - Add support for mad (high-quality mp3 decoder library and cli frontend)
+magic - Add support for file type detection via magic bytes (usually via libmagic from sys-apps/file)
 maildir - Add support for maildir (~/.maildir) style mail spools
 matroska - Add support for the matroska container format (extensions .mkv, .mka and .mks)
 mbox - Add support for mbox (/var/spool/mail) style mail spools
-- 
2.23.0.rc1

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 2336 bytes --]

The USE flag naming feels a bit to be desired by me.
That's because I don't believe in USE flags having to be named by the
external dep they introduce, but by functionality. USE=magic sounds
like a USE flag that adds some wizards into your application, automagic
behavior or who knows (until you read the description).
Not that I have a much better suggestion. USE=auto-mimetypes?

Mart


Ühel kenal päeval, P, 11.08.2019 kell 13:21, kirjutas Michał Górny:
> USE=magic is currently used consistently by 12 packages:
> 
> app-arch/engrampa[magic] Enable filetype auto-detection via
>   sys-apps/file
> app-editors/nano[magic] Add magic file support (sys-apps/file) to
>   automatically detect appropriate syntax highlighting
> app-misc/vifm[magic] Use libmagic to determine mimetypes
> app-misc/worker[magic] Add magic file support from sys-apps/file to
>   automatically detect file types
> app-text/zathura[magic] Use libmagic to determine mimetypes
> media-gfx/qiv[magic] Use libmagic to determine mimetypes
> media-libs/libextractor[magic] Enable magic support using sys-
> apps/file
> media-sound/moc[magic] Use libmagic to determine mimetypes
> net-misc/gerbera[magic] Use libmagic to determine file types
> net-p2p/mldonkey[magic] enable use of libmagic
> sci-geosciences/viking[magic] Use libmagic to determine mimetypes
> www-servers/pshs[magic] Enable automatic detection of Content-Type
> using
>   libmagic (sys-apps/file)
> 
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  profiles/use.desc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/profiles/use.desc b/profiles/use.desc
> index 13baef969315..09940dd81822 100644
> --- a/profiles/use.desc
> +++ b/profiles/use.desc
> @@ -181,6 +181,7 @@ lzma - Support for LZMA (de)compression algorithm
>  lzo - Enable support for lzo compression
>  m17n-lib - Enable m17n-lib support
>  mad - Add support for mad (high-quality mp3 decoder library and cli
> frontend)
> +magic - Add support for file type detection via magic bytes (usually
> via libmagic from sys-apps/file)
>  maildir - Add support for maildir (~/.maildir) style mail spools
>  matroska - Add support for the matroska container format (extensions
> .mkv, .mka and .mks)
>  mbox - Add support for mbox (/var/spool/mail) style mail spools

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 704 bytes --]

On Sun, 2019-08-11 at 14:46 +0300, Mart Raudsepp wrote:
> The USE flag naming feels a bit to be desired by me.
> That's because I don't believe in USE flags having to be named by the
> external dep they introduce, but by functionality. USE=magic sounds
> like a USE flag that adds some wizards into your application, automagic
> behavior or who knows (until you read the description).
> Not that I have a much better suggestion. USE=auto-mimetypes?
> 

The use of term 'magic' for file type recognition by magic bytes is well
established.  Standing on your head and trying to invent an alternative
is not going to help anyone, and only confuse people.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

Ühel kenal päeval, P, 11.08.2019 kell 14:53, kirjutas Michał Górny:
> On Sun, 2019-08-11 at 14:46 +0300, Mart Raudsepp wrote:
> > The USE flag naming feels a bit to be desired by me.
> > That's because I don't believe in USE flags having to be named by
> > the
> > external dep they introduce, but by functionality. USE=magic sounds
> > like a USE flag that adds some wizards into your application,
> > automagic
> > behavior or who knows (until you read the description).
> > Not that I have a much better suggestion. USE=auto-mimetypes?
> > 
> 
> The use of term 'magic' for file type recognition by magic bytes is
> well established.

Fair enough.

> Standing on your head and trying to invent an
> alternative
> is not going to help anyone, and only confuse people.

Completely uncalled for unfriendly hostile additional sentence.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Sun, 2019-08-11 at 16:45 +0300, Mart Raudsepp wrote:
> Ühel kenal päeval, P, 11.08.2019 kell 14:53, kirjutas Michał Górny:
> > On Sun, 2019-08-11 at 14:46 +0300, Mart Raudsepp wrote:
> > > The USE flag naming feels a bit to be desired by me.
> > > That's because I don't believe in USE flags having to be named by
> > > the
> > > external dep they introduce, but by functionality. USE=magic sounds
> > > like a USE flag that adds some wizards into your application,
> > > automagic
> > > behavior or who knows (until you read the description).
> > > Not that I have a much better suggestion. USE=auto-mimetypes?
> > > 
> > 
> > The use of term 'magic' for file type recognition by magic bytes is
> > well established.
> 
> Fair enough.
> 
> > Standing on your head and trying to invent an
> > alternative
> > is not going to help anyone, and only confuse people.
> 
> Completely uncalled for unfriendly hostile additional sentence.

I didn't mean to be hostile.  I just meant to visually explain that your
suggestion is long way from the initial point (hence 'standing on your
head'), and it's going to be confusing.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Haelwenn (lanodan) Monnier]

[2019-08-11 14:53:34+0200] Michał Górny:
> On Sun, 2019-08-11 at 14:46 +0300, Mart Raudsepp wrote:
> > The USE flag naming feels a bit to be desired by me.
> > That's because I don't believe in USE flags having to be named by the
> > external dep they introduce, but by functionality. USE=magic sounds
> > like a USE flag that adds some wizards into your application, automagic
> > behavior or who knows (until you read the description).
> > Not that I have a much better suggestion. USE=auto-mimetypes?
> > 
> 
> The use of term 'magic' for file type recognition by magic bytes is well
> established.

Yes, but `magic` doesn't really gives much of an idea on the feature 
and could get a bit of confusion, I think `libmagic` is better on this 
regard as it's closer to what would be used without much context and 
it's clear that it's about a dependency on sys-apps/file and not some 
kind of magic feature (which is a quite overloaded word in computing).

(auto-mimetype doesn't works at all btw, file/libmagic is much more 
precise than mimetypes)

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Kent Fredric]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

On Sun, 11 Aug 2019 14:53:34 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> The use of term 'magic' for file type recognition by magic bytes is well
> established.  Standing on your head and trying to invent an alternative
> is not going to help anyone, and only confuse people.

Fun fact: when I saw this Subject on the ml, I assumed it was probably
going to be a poorly named flag for features provided by ImageMagick.

But I guess that'd be magick, not magic.

"magic" is too overloaded a term :/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Pacho Ramos]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

El dom, 11-08-2019 a las 13:21 +0200, Michał Górny escribió:
> USE=magic is currently used consistently by 12 packages:
> 
> app-arch/engrampa[magic] Enable filetype auto-detection via
>   sys-apps/file
> app-editors/nano[magic] Add magic file support (sys-apps/file) to
>   automatically detect appropriate syntax highlighting
> app-misc/vifm[magic] Use libmagic to determine mimetypes
> app-misc/worker[magic] Add magic file support from sys-apps/file to
>   automatically detect file types
> app-text/zathura[magic] Use libmagic to determine mimetypes
> media-gfx/qiv[magic] Use libmagic to determine mimetypes
> media-libs/libextractor[magic] Enable magic support using sys-apps/file
> media-sound/moc[magic] Use libmagic to determine mimetypes
> net-misc/gerbera[magic] Use libmagic to determine file types
> net-p2p/mldonkey[magic] enable use of libmagic
> sci-geosciences/viking[magic] Use libmagic to determine mimetypes
> www-servers/pshs[magic] Enable automatic detection of Content-Type using
>   libmagic (sys-apps/file)

It seems it should also cover, if possible, this to packages that use an
alternative name:

dev-python/jira:filemagic - Include filemagic support (for identifying uploaded
filetypes)
dev-vcs/git-annex:magicmime - Use libmagic to determine file MIME types


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

On Sun, 2019-08-11 at 13:21 +0200, Michał Górny wrote:
> USE=magic is currently used consistently by 12 packages:
> 

Merged.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Fabian Groffen]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi Michał,

It looks like you missed two from your original set?

app-editors/nano[magic] Add magic file support (sys-apps/file) to
automatically detect appropriate syntax highlighting
www-servers/pshs[magic] Enable automatic detection of Content-Type using
libmagic (sys-apps/file)

Thanks,
Fabian

On 19-08-2019 22:04:12 +0200, Michał Górny wrote:
> On Sun, 2019-08-11 at 13:21 +0200, Michał Górny wrote:
> > USE=magic is currently used consistently by 12 packages:
> > 
> 
> Merged.
> 
> -- 
> Best regards,
> Michał Górny
> 



-- 
Fabian Groffen
Gentoo on a different level

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] [PATCH] use.desc: Introduce global USE=magic

[Michał Górny]

Dnia August 20, 2019 6:49:28 AM UTC, Fabian Groffen <grobian@gentoo.org> napisał(a):
>Hi Michał,
>
>It looks like you missed two from your original set?
>
>app-editors/nano[magic] Add magic file support (sys-apps/file) to
>automatically detect appropriate syntax highlighting
>www-servers/pshs[magic] Enable automatic detection of Content-Type
>using
>libmagic (sys-apps/file)

I've left them intentionally as they provide more information on what magic support provides.

>
>Thanks,
>Fabian
>
>On 19-08-2019 22:04:12 +0200, Michał Górny wrote:
>> On Sun, 2019-08-11 at 13:21 +0200, Michał Górny wrote:
>> > USE=magic is currently used consistently by 12 packages:
>> > 
>> 
>> Merged.
>> 
>> -- 
>> Best regards,
>> Michał Górny
>> 


--
Best regards, 
Michał Górny