From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 68B52139360 for ; Wed, 11 Aug 2021 12:41:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3B927E0833; Wed, 11 Aug 2021 12:41:06 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 56BC6E07F9 for ; Wed, 11 Aug 2021 12:41:05 +0000 (UTC) From: Andreas Sturmlechner To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v3 1/2] xdg.eclass: add EAPI 8 support Date: Wed, 11 Aug 2021 14:40:50 +0200 Message-ID: <2036961.9o76ZdvQCi@tuxbook> In-Reply-To: <207455ff-2d55-6ec4-6e7a-e04aa5ba08a0@gentoo.org> References: <20210721150849.175482-1-flow@gentoo.org> <2555139.vuYhMxLoTh@tuxbook> <207455ff-2d55-6ec4-6e7a-e04aa5ba08a0@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2566548.vuYhMxLoTh"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Archives-Salt: 78d8a617-6b3c-4e1c-a3f2-dbeb8f79a741 X-Archives-Hash: 70ffb40ddf6b5217b25cdbfe94bb57f7 --nextPart2566548.vuYhMxLoTh Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Andreas Sturmlechner To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v3 1/2] xdg.eclass: add EAPI 8 support Date: Wed, 11 Aug 2021 14:40:50 +0200 Message-ID: <2036961.9o76ZdvQCi@tuxbook> In-Reply-To: <207455ff-2d55-6ec4-6e7a-e04aa5ba08a0@gentoo.org> References: <20210721150849.175482-1-flow@gentoo.org> <2555139.vuYhMxLoTh@tuxbook> <207455ff-2d55-6ec4-6e7a-e04aa5ba08a0@gentoo.org> On Mittwoch, 11. August 2021 13:54:19 CEST Florian Schmaus wrote: > On 10/08/2021 10.31, Andreas Sturmlechner wrote: > > On Montag, 9. August 2021 20:32:07 CEST Florian Schmaus wrote: > >> +if ${_DEFINE_XDG_SRC_PREPARE}; then > > > > You don't need an extra variable for that: > > > > if [[ ${EAPI} == [567] ]]; then > > Thanks for the suggestion, but I prefer the current approach. > > It avoids that someone later drops support for EAPI 5 and forgets > adjusting all the cases where it is mentioned. I think your other > suggestion, that dropping EAPI 4 in xdg_src_prepare() when removing > support for EAPI 4 was forgotten, somehow reinforces my point. :) Not really. Having to search for EAPI in the code is obvious when cleaning up EAPI, and is standard across many eclasses. If you miss that, you could just as well have _DEFINE_XDG_SRC_PREPARE linger on below after cleaning up the initialisation. Regards --nextPart2566548.vuYhMxLoTh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEexlipVqzuLtTjHMOREsPlv/SLMsFAmETxVJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDdC MTk2MkE1NUFCM0I4QkI1MzhDNzMwRTQ0NEIwRjk2RkZEMjJDQ0IACgkQREsPlv/S LMsPUwf/dnWv5wHfuaBHz0pRzWaXVLc/7RaEvdbyL1rXQ9K7K6mhpd5BwVniehX/ tlnJS4cwKwbyMPkaUUkQd0H4DCDlKZprYzllacjA11stCOv8VHBYnixeI/IzPqrQ 7ulrahxkj8glh/PfMfZP7LjUhe27Mg42QV/+MBzuiznJfxndQTGc/LTDmXskYY43 ZrVFxJCk78HzZ4CnTPX//ayLGOP3nGUg5VDUVAPFNfXZRgfyA5bD4inizmvqTKE6 YXvIuwLFVEx3s2cWQo9YEThjXBF5VjHFrOkY6ZDMCAu6pdLMFMaD8BPPpHfgf/Fq G1YbD6bDQTg8BTxaU+VHtWp13EflMw== =cZub -----END PGP SIGNATURE----- --nextPart2566548.vuYhMxLoTh--