Re: [gentoo-dev] [PATCH v3 1/2] xdg.eclass: add EAPI 8 support

[Andreas Sturmlechner <asturm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

On Mittwoch, 11. August 2021 13:54:19 CEST Florian Schmaus wrote:
> On 10/08/2021 10.31, Andreas Sturmlechner wrote:
> > On Montag, 9. August 2021 20:32:07 CEST Florian Schmaus wrote:
> >> +if ${_DEFINE_XDG_SRC_PREPARE}; then
> > 
> > You don't need an extra variable for that:
> > 
> > if [[ ${EAPI} == [567] ]]; then
> 
> Thanks for the suggestion, but I prefer the current approach.
> 
> It avoids that someone later drops support for EAPI 5 and forgets
> adjusting all the cases where it is mentioned. I think your other
> suggestion, that dropping EAPI 4 in xdg_src_prepare() when removing
> support for EAPI 4 was forgotten, somehow reinforces my point. :)

Not really. Having to search for EAPI in the code is obvious when cleaning up 
EAPI, and is standard across many eclasses. If you miss that, you could just 
as well have _DEFINE_XDG_SRC_PREPARE linger on below after cleaning up the 
initialisation.

Regards

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 618 bytes --]