public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: James Le Cuirot <chewi@gentoo.org>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Cc: William Hubbs <williamh@gentoo.org>, James Le Cuirot <chewi@gentoo.org>
Subject: [gentoo-dev] [PATCH 7/8] go-env.eclass: Add the go-env_goos() helper function
Date: Tue,  9 Jul 2024 22:07:39 +0100	[thread overview]
Message-ID: <20240709210749.14002-7-chewi@gentoo.org> (raw)
In-Reply-To: <20240709210749.14002-1-chewi@gentoo.org>

This code is taken from dev-lang/go. No other packages have code like
this, but some erroneously call `go env GOOS`, which is bad for
cross-compiling. They should use this function instead.

Signed-off-by: James Le Cuirot <chewi@gentoo.org>
---
 eclass/go-env.eclass | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/eclass/go-env.eclass b/eclass/go-env.eclass
index c839c41be0d7e..be131133113be 100644
--- a/eclass/go-env.eclass
+++ b/eclass/go-env.eclass
@@ -48,6 +48,24 @@ go-env_set_compile_environment() {
 	export CGO_LDFLAGS="${CGO_LDFLAGS:-$LDFLAGS}"
 }
 
+# @FUNCTION: go-env_goos
+# @USAGE: [toolchain prefix]
+# @DESCRIPTION:
+# Returns the appropriate GOOS setting for the target operating system.
+go-env_goos() {
+	local target=${1:-${CHOST}}
+	case "${target}" in
+		*-linux*) echo linux ;;
+		*-darwin*) echo darwin ;;
+		*-freebsd*) echo freebsd ;;
+		*-netbsd*) echo netbsd ;;
+		*-openbsd*) echo openbsd ;;
+		*-solaris*) echo solaris ;;
+		*-cygwin*|*-interix*|*-winnt*) echo windows ;;
+		*) die "unknown GOOS for ${target}" ;;
+	esac
+}
+
 # @FUNCTION: go-env_goarch
 # @USAGE: [toolchain prefix]
 # @DESCRIPTION:
-- 
2.45.2



  parent reply	other threads:[~2024-07-09 21:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 21:07 [gentoo-dev] [PATCH 1/8] golang-vcs.eclass: Drop support for EAPI 6 James Le Cuirot
2024-07-09 21:07 ` [gentoo-dev] [PATCH 2/8] golang-vcs-snapshot.eclass: " James Le Cuirot
2024-07-09 21:07 ` [gentoo-dev] [PATCH 3/8] golang-build.eclass: " James Le Cuirot
2024-07-09 21:07 ` [gentoo-dev] [PATCH 4/8] golang-base.eclass: Drop support for EAPI 5 and 6 James Le Cuirot
2024-07-09 21:07 ` [gentoo-dev] [PATCH 5/8] go-env.eclass: Establish EAPI 7 and 8 as supported James Le Cuirot
2024-07-09 21:07 ` [gentoo-dev] [PATCH 6/8] go-env.eclass: Rewrite the go-env_goarch() logic James Le Cuirot
2024-07-09 21:07 ` James Le Cuirot [this message]
2024-07-09 21:07 ` [gentoo-dev] [PATCH 8/8] dev-lang/go: Use go-env.eclass in 1.22.5 and 9999 James Le Cuirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240709210749.14002-7-chewi@gentoo.org \
    --to=chewi@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=williamh@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox